RE: Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0] by amosbastian

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @t3ran13/update-of-php-graphene-node-client-v5-1-2-v5-2-0

utopian-io · @amosbastian · Mar 5 '19

$13.16

Welcome back! It's cool to see you guys are still actively working on this, as I remember seeing some posts about this project before. Here is some feedback:

* In the comparison there are some commits > 14 days old - even if we are sort of lenient with this, try and keep it below.
* Some magic numbers like `16511` and variables called `n2`, `n3` etc. - could make into constants and make more descriptive respectively.
* Could provide a description of what the function does instead of only having the arguments' names and types.
* Some funny indentation in the lists. Is lining up everything like this common in PHP?

Am interested to see what kind of features you guys add next. Any specific plans?

---

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-1-2-1-2-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, mightypanda, holger80, espoem, t3ran13, organicgardener, ulockblock, mys, emrebeyler, monster-inc, steemtaker, aydant, fastandcurious, ascorphat, amico, mbot, linknotfound, shammi, oscarliam, php-node-client

`author`	amosbastian
`permlink`	re-t3ran13-update-of-php-graphene-node-client-v5-1-2-v5-2-0-20190305t195727669z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"links":["https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-2-2-1-2-1-2-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
`created`	2019-03-05 19:57:27
`last_update`	2019-03-05 19:57:27
`depth`	1
`children`	4
`last_payout`	2019-03-12 19:57:27
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	9.965 HBD
`curator_payout_value`	3.199 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	1,158
`author_reputation`	174,473,586,900,705
`root_title`	"Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	80,785,516
`net_rshares`	17,447,515,884,722
`author_curate_reward`	""

properties (23)vote details (20)

voter	rshares	pct
t3ran13	23,820,117,918	100%
php-node-client	3,307,511	1%
mys	7,439,039,354	8.56%
espoem	28,943,909,675	15%
utopian-io	17,023,387,014,044	12.11%
shammi	406,759,948	7%
emrebeyler	6,641,879,685	1%
steemtaker	6,026,991,775	6%
aydant	5,215,706,870	50%
organicgardener	10,885,997,099	35%
holger80	60,348,165,342	10%
amico	961,619,547	0.33%
mbot	506,019,841	100%
mightypanda	250,734,771,539	100%
ulockblock	9,003,590,400	2.97%
fastandcurious	4,252,847,929	100%
linknotfound	499,489,999	100%
ascorphat	2,104,746,801	2.5%
monster-inc	6,260,179,157	100%
oscarliam	73,730,288	100%

@t3ran13 · Mar 5 '19

Hi :)
Thanks for feedback!

> Some funny indentation in the lists. Is lining up everything like this common in PHP?

It is my style more than PSR, but at most it corresponds to PSR =)

> Am interested to see what kind of features you guys add next. Any specific plans?

I do not have so much time as before and i am working ander other project - subchain for steem/viz chains.
i have some ideas about improvements for lib and i will add it in future

properties (22)

`author`	t3ran13
`permlink`	re-amosbastian-re-t3ran13-update-of-php-graphene-node-client-v5-1-2-v5-2-0-20190305t202211662z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"app":"steemit/0.1"}
`created`	2019-03-05 20:23:30
`last_update`	2019-03-05 20:23:30
`depth`	2
`children`	2
`last_payout`	2019-03-12 20:23:30
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	449
`author_reputation`	50,037,290,585,145
`root_title`	"Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	80,786,428
`net_rshares`	0

@amosbastian · Mar 5 '19

It's the 2nd time this week I've seen indentation like this, pretty funny. It reminds me of what I used to do when I first started programming because I thought it looked nice, and then someone told me off lol.

👍 steemtaker, cheneats, shammi, oscarliam

`author`	amosbastian
`permlink`	re-t3ran13-re-amosbastian-re-t3ran13-update-of-php-graphene-node-client-v5-1-2-v5-2-0-20190305t214724787z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"app":"steemit/0.1"}
`created`	2019-03-05 21:47:24
`last_update`	2019-03-05 21:47:24
`depth`	3
`children`	1
`last_payout`	2019-03-12 21:47:24
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	210
`author_reputation`	174,473,586,900,705
`root_title`	"Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	80,789,440
`net_rshares`	8,393,197,877
`author_curate_reward`	""

properties (23)vote details (4)

voter	rshares	pct
shammi	406,466,483	7%
steemtaker	6,094,677,098	6%
cheneats	1,819,058,109	24%
oscarliam	72,996,187	100%

@php-node-client · Mar 7 '19

))) it is

properties (22)

`author`	php-node-client
`permlink`	re-amosbastian-re-t3ran13-re-amosbastian-re-t3ran13-update-of-php-graphene-node-client-v5-1-2-v5-2-0-20190307t054711210z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"app":"steemit/0.1"}
`created`	2019-03-07 05:47:12
`last_update`	2019-03-07 05:47:12
`depth`	4
`children`	0
`last_payout`	2019-03-14 05:47:12
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	9
`author_reputation`	574,145,594,155
`root_title`	"Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	80,855,488
`net_rshares`	0

@utopian-io · Mar 7 '19

Thank you for your review, @amosbastian! Keep up the good work!

properties (22)