create account

My First Steemit Pull Request by bacchist

View this thread on: hive.blog |  peakd.com |  ecency.com
steemit · @bacchist ·
$368.19
My First Steemit Pull Request
I'm not a "real" developer. More of a savvy user or enthusiast. So I'm pretty pleased with myself after having **my first pull request accepted** for Steemit's condenser platform.

<center>http://i.imgur.com/IA7BEiv.png</center>

For those who don't know, the codebase for steemit.com is open source and [available on github](https://github.com/steemit/condenser). Anybody with the skill and desire to do so can contribute to the web site. I have a few ideas for improvements to the site that seem simple enough, so I've looked around the source a bit. I wasn't able to figure out how to implement my ideas, but I recently came across a problem that put well meaning users at risk of losing SBD.

By now a lot of us have heard about @randowhale. He's a new whale account set up specifically to let users spend 2 SBD to get a random vote, which may end up increasing their earnings above the 2 SBD they spent. Cool idea, right?!

Well... Apparently somebody decided that it would be a good opportunity to take advantage of people, and essentially steal money from people for making a simple mistake....

<center>http://i.imgur.com/b4oNvri.png</center>

Serial small time scammer and troll @noganoo registered the name @randomwhale in order to steal from the honest members of our community. By the time I learned about it, he had already taken 10 SBD from users who made a simple mistake. (which would not have been possible until he created his scam account... the blockchain won't let you send tokens to accounts which don't exist!)

From poking around before, I knew where to find the list of "bad actors" that the wallet warns you about during transfers.

<center>http://i.imgur.com/eRw8SVZ.png</center>

I knew that by adding @randomwhale to the list, it might help users avoid the scam that others had already fallen victim to. It was a little thing, but it could help. So I decided to give it a shot. And with the help of @lukestokes, who walked me through the process of forking the repository, committing my changes, and finally submitting the pull request... I did it!

After a bit of time, I  got a notification that it had been reviewed. @sneak accepted it and merged it! Soon, when a user accidentally fills in "randomwhale", they will get a notice to check the name they are sending to.

I'm remarkably proud for having done so little! :D
👍  , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , and 150 others
properties (23)
authorbacchist
permlinkmy-first-steemit-pull-request
categorysteemit
json_metadata{"tags":["steemit","brag-post","skillz","randowhale","scam-warning"],"users":["randowhale","noganoo","randomwhale","lukestokes","sneak"],"image":["http://i.imgur.com/IA7BEiv.png","http://i.imgur.com/b4oNvri.png","http://i.imgur.com/eRw8SVZ.png"],"links":["https://github.com/steemit/condenser"],"app":"steemit/0.1","format":"markdown"}
created2017-06-16 01:21:48
last_update2017-06-16 01:21:48
depth0
children21
last_payout2017-06-23 01:21:48
cashout_time1969-12-31 23:59:59
total_payout_value310.074 HBD
curator_payout_value58.117 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length2,351
author_reputation85,392,357,715,964
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,968,897
net_rshares16,332,147,346,585
author_curate_reward""
vote details (214)
@brianphobos · 
Great job man!  Every little improvement helps a ton!
properties (22)
authorbrianphobos
permlinkre-bacchist-my-first-steemit-pull-request-20170616t015535727z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 01:55:36
last_update2017-06-16 01:55:36
depth1
children0
last_payout2017-06-23 01:55:36
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length53
author_reputation174,046,007,429,665
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,971,194
net_rshares0
@jamjamfood · 
Great, that you react and make it public. Good to know. I want to use Randowhale next time. So I have reminder now for the right thing.
properties (22)
authorjamjamfood
permlinkre-bacchist-my-first-steemit-pull-request-20170629t190859567z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-29 19:08:57
last_update2017-06-29 19:08:57
depth1
children0
last_payout2017-07-06 19:08:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length135
author_reputation5,026,227,246,530
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id6,663,993
net_rshares0
@jbouchard12 ·
$1.89
thank you. I recently made a post praising randowhale for making steemit even more fun. someone commented and wrote how much they loved @randomwhale. they commented the wrong name on my post and it had to be cleared up! hope what you did helps!
👍  , ,
properties (23)
authorjbouchard12
permlinkre-bacchist-my-first-steemit-pull-request-20170616t013548368z
categorysteemit
json_metadata{"tags":["steemit"],"users":["randomwhale"],"app":"steemit/0.1"}
created2017-06-16 01:35:51
last_update2017-06-16 01:35:51
depth1
children0
last_payout2017-06-23 01:35:51
cashout_time1969-12-31 23:59:59
total_payout_value1.848 HBD
curator_payout_value0.045 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length244
author_reputation9,430,846,720,503
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,969,840
net_rshares84,172,729,534
author_curate_reward""
vote details (3)
@jhermanbeans ·
$17.62
That's awesome! Takes balls to tackle something for the first time!

![fist-pump-baby-you-did-it-.jpg](https://steemitimages.com/DQmZmyfgaYmuDoydkzjJALSP8BJbABPGXcGPNhvDbKBzuvd/fist-pump-baby-you-did-it-.jpg)
👍  , , , , , , , , , , , ,
properties (23)
authorjhermanbeans
permlinkre-bacchist-my-first-steemit-pull-request-20170616t014859170z
categorysteemit
json_metadata{"tags":["steemit"],"image":["https://steemitimages.com/DQmZmyfgaYmuDoydkzjJALSP8BJbABPGXcGPNhvDbKBzuvd/fist-pump-baby-you-did-it-.jpg"],"app":"steemit/0.1"}
created2017-06-16 01:48:57
last_update2017-06-16 01:48:57
depth1
children0
last_payout2017-06-23 01:48:57
cashout_time1969-12-31 23:59:59
total_payout_value13.226 HBD
curator_payout_value4.397 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length208
author_reputation7,087,710,222,074
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,970,789
net_rshares783,233,823,184
author_curate_reward""
vote details (13)
@kendewitt ·
$0.03
How is it that this guy still has a 64 reputation with all those posts hidden due to low ratings?
👍  
properties (23)
authorkendewitt
permlinkre-bacchist-my-first-steemit-pull-request-20170616t033701278z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 03:37:00
last_update2017-06-16 03:37:00
depth1
children0
last_payout2017-06-23 03:37:00
cashout_time1969-12-31 23:59:59
total_payout_value0.020 HBD
curator_payout_value0.006 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length97
author_reputation10,022,764,530,440
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,976,743
net_rshares1,303,431,602
author_curate_reward""
vote details (1)
@moomoo · 
lgtm, ship it
properties (22)
authormoomoo
permlinkre-bacchist-my-first-steemit-pull-request-20170616t023654190z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 02:36:54
last_update2017-06-16 02:36:54
depth1
children0
last_payout2017-06-23 02:36:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length13
author_reputation107,285,019,305
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,973,492
net_rshares0
@randowhale ·
$5.51
This post received a 7% upvote from @randowhale thanks to @bacchist!  For more information, [click here](https://steemit.com/steemit/@randowhale/introducing-randowhale-will-you-get-the-100-vote-give-it-a-shot)!
👍  ,
properties (23)
authorrandowhale
permlinkre-my-first-steemit-pull-request-20170617t173920
categorysteemit
json_metadata"{"format": "markdown", "app": "randowhale/0.1"}"
created2017-06-17 17:39:21
last_update2017-06-17 17:39:21
depth1
children0
last_payout2017-06-24 17:39:21
cashout_time1969-12-31 23:59:59
total_payout_value4.510 HBD
curator_payout_value0.996 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length210
author_reputation47,657,457,485,459
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id5,111,088
net_rshares264,423,789,046
author_curate_reward""
vote details (2)
@rusticman1 · 
The world needs more guys like you.  Watching out for the community.
properties (22)
authorrusticman1
permlinkre-bacchist-my-first-steemit-pull-request-20170616t023654134z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 02:36:54
last_update2017-06-16 02:36:54
depth1
children0
last_payout2017-06-23 02:36:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length68
author_reputation275,518,825,217
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,973,490
net_rshares0
@scaredycatguide · 
Holy crap man, that is awesome!  Same boat as you, savvy user....just enough to get ourselves int some trouble, but you did indeed go down the rabbit whole to make this option available.  Good stuff!
properties (22)
authorscaredycatguide
permlinkre-bacchist-my-first-steemit-pull-request-20170616t013331866z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 01:33:36
last_update2017-06-16 01:33:36
depth1
children0
last_payout2017-06-23 01:33:36
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length199
author_reputation983,830,944,597,016
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,969,692
net_rshares0
@stay9n0 · 
Thx bacchist!

We do need a system to remind Steemian who are bad.
Really nice idea !
Resteemed! Let's more ppl know your idea.
properties (22)
authorstay9n0
permlinkre-bacchist-2017616t123458793z
categorysteemit
json_metadata{"tags":"steemit","app":"esteem/1.4.5","format":"markdown+html","community":"esteem"}
created2017-06-16 04:35:03
last_update2017-06-16 04:35:03
depth1
children0
last_payout2017-06-23 04:35:03
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length127
author_reputation1,452,017,590,144
root_title"My First Steemit Pull Request"
beneficiaries
0.
accountesteemapp
weight500
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,980,087
net_rshares0
@steemitboard · 
Congratulations @bacchist! You have completed some achievement on Steemit and have been rewarded with new badge(s) :

[![](https://steemitimages.com/70x80/http://steemitboard.com/notifications/votes.png)](http://steemitboard.com/@bacchist) Award for the number of upvotes

Click on any badge to view your own Board of Honnor on SteemitBoard.
For more information about SteemitBoard, click [here](https://steemit.com/@steemitboard)

If you no longer want to receive notifications, reply to this comment with the word `STOP`

By upvoting this notification, you can help all Steemit users. Learn how [here](https://steemit.com/steemitboard/@steemitboard/http-i-cubeupload-com-7ciqeo-png)!
properties (22)
authorsteemitboard
permlinksteemitboard-notify-bacchist-20170617t221730000z
categorysteemit
json_metadata{"image":["https://steemitboard.com/img/notifications.png"]}
created2017-06-17 20:17:30
last_update2017-06-17 20:17:30
depth1
children0
last_payout2017-06-24 20:17:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length685
author_reputation38,975,615,169,260
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id5,121,656
net_rshares0
@steemitboard · 
Congratulations @bacchist! You have completed some achievement on Steemit and have been rewarded with new badge(s) :

[![](https://steemitimages.com/70x80/http://steemitboard.com/notifications/payout.png)](http://steemitboard.com/@bacchist) Award for the total payout received

Click on any badge to view your own Board of Honnor on SteemitBoard.
For more information about SteemitBoard, click [here](https://steemit.com/@steemitboard)

If you no longer want to receive notifications, reply to this comment with the word `STOP`

By upvoting this notification, you can help all Steemit users. Learn how [here](https://steemit.com/steemitboard/@steemitboard/http-i-cubeupload-com-7ciqeo-png)!
properties (22)
authorsteemitboard
permlinksteemitboard-notify-bacchist-20170620t173718000z
categorysteemit
json_metadata{"image":["https://steemitboard.com/img/notifications.png"]}
created2017-06-20 15:37:36
last_update2017-06-20 15:37:36
depth1
children0
last_payout2017-06-27 15:37:36
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length690
author_reputation38,975,615,169,260
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id5,362,279
net_rshares0
@streetstyle · (edited)
@bacchist In fairness, noganoo did get back to me stating that he would be implementing a similar system as randOwhale, The last I checked he did up vote those who had mistakenly sent money to his  acct ... i am hoping that this remains the case.
properties (22)
authorstreetstyle
permlinkre-bacchist-my-first-steemit-pull-request-20170616t012828606z
categorysteemit
json_metadata{"tags":["steemit"],"users":["bacchist"],"app":"steemit/0.1"}
created2017-06-16 01:28:27
last_update2017-06-16 01:28:57
depth1
children2
last_payout2017-06-23 01:28:27
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length246
author_reputation179,664,473,611,368
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,969,347
net_rshares0
@bacchist · 
With his track record, I can't give him any credit for having good intentions.
properties (22)
authorbacchist
permlinkre-streetstyle-re-bacchist-my-first-steemit-pull-request-20170616t013326753z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 01:33:27
last_update2017-06-16 01:33:27
depth2
children1
last_payout2017-06-23 01:33:27
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length78
author_reputation85,392,357,715,964
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,969,682
net_rshares0
@streetstyle ·
$1.78
well at least I now know who to go to in case I run into something like this again. I was one of the first ones to make that mistake. Thanks and way to go @bacchist
👍  ,
properties (23)
authorstreetstyle
permlinkre-bacchist-re-streetstyle-re-bacchist-my-first-steemit-pull-request-20170616t021541046z
categorysteemit
json_metadata{"tags":["steemit"],"users":["bacchist"],"app":"steemit/0.1"}
created2017-06-16 02:15:42
last_update2017-06-16 02:15:42
depth3
children0
last_payout2017-06-23 02:15:42
cashout_time1969-12-31 23:59:59
total_payout_value1.338 HBD
curator_payout_value0.443 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length164
author_reputation179,664,473,611,368
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,972,277
net_rshares79,390,065,660
author_curate_reward""
vote details (2)
@teamsteem · 
Good move and congrats!
properties (22)
authorteamsteem
permlinkre-bacchist-my-first-steemit-pull-request-20170616t025924282z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 02:58:51
last_update2017-06-16 02:58:51
depth1
children0
last_payout2017-06-23 02:58:51
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length23
author_reputation284,804,541,406,803
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,974,724
net_rshares0
@themevlog · 
thanks for the post, it's a good warning...I would hate to waste 2 sbd for nothing...upvoted and followed.
properties (22)
authorthemevlog
permlinkre-bacchist-my-first-steemit-pull-request-20170616t014843690z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 01:48:51
last_update2017-06-16 01:48:51
depth1
children0
last_payout2017-06-23 01:48:51
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length106
author_reputation1,412,401,272,134
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,970,775
net_rshares0
@theprophet0 ·
$1.73
Congrats man! I plan to start learning C++ tomorrow, I want to be a dev for a living!
👍  ,
properties (23)
authortheprophet0
permlinkre-bacchist-my-first-steemit-pull-request-20170616t043803465z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 04:38:03
last_update2017-06-16 04:38:03
depth1
children1
last_payout2017-06-23 04:38:03
cashout_time1969-12-31 23:59:59
total_payout_value1.302 HBD
curator_payout_value0.430 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length85
author_reputation42,005,134,378,165
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,980,265
net_rshares77,656,622,937
author_curate_reward""
vote details (2)
@bacchist ·
$9.65
You can do literally anything you want. You're ahead of the curve. It's up to you. ;)
👍  , ,
properties (23)
authorbacchist
permlinkre-theprophet0-re-bacchist-my-first-steemit-pull-request-20170616t053909805z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 05:39:09
last_update2017-06-16 05:39:09
depth2
children0
last_payout2017-06-23 05:39:09
cashout_time1969-12-31 23:59:59
total_payout_value8.572 HBD
curator_payout_value1.077 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length85
author_reputation85,392,357,715,964
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,983,467
net_rshares433,346,196,096
author_curate_reward""
vote details (3)
@timcliff ·
$1.81
Grats on your first pull request! Great change to check in. Thanks for doing this :)
👍  , ,
properties (23)
authortimcliff
permlinkre-bacchist-my-first-steemit-pull-request-20170616t023001036z
categorysteemit
json_metadata{"tags":["steemit"],"app":"steemit/0.1"}
created2017-06-16 02:30:00
last_update2017-06-16 02:30:00
depth1
children0
last_payout2017-06-23 02:30:00
cashout_time1969-12-31 23:59:59
total_payout_value1.362 HBD
curator_payout_value0.448 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length84
author_reputation272,954,445,077,789
root_title"My First Steemit Pull Request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,973,098
net_rshares80,693,497,262
author_curate_reward""
vote details (3)
@wallsnow ·
$1.70
No @randomwhale but @randowhale
👍  , ,
properties (23)
authorwallsnow
permlinkre-bacchist-2017616t102458269z
categorysteemit
json_metadata{"tags":"steemit","app":"esteem/1.4.5","format":"markdown+html","community":"esteem"}
created2017-06-16 02:25:03
last_update2017-06-16 02:25:03
depth1
children0
last_payout2017-06-23 02:25:03
cashout_time1969-12-31 23:59:59
total_payout_value1.262 HBD
curator_payout_value0.437 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length31
author_reputation199,985,198,977
root_title"My First Steemit Pull Request"
beneficiaries
0.
accountesteemapp
weight500
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id4,972,801
net_rshares78,616,098,807
author_curate_reward""
vote details (3)
Help/Feedback