create account

eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc. by blockchainstudio

View this thread on: hive.blogpeakd.comecency.com
· @blockchainstudio · (edited)
$13.40
eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc.
#### Repository
https://github.com/esteemapp/esteem-surfer

**Note**: Regarding comment and coding style, as an external contributor,  I followed the PO's practice. Comments were rarely used in the original code, so I only made a comment when it's really needed. In addition, I wrote the details in  commit/issue/PR.

**Note2**: My recent [dev post](https://steemit.com/utopian-io/@blockchainstudio/busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc) couldn't be voted due to the limited VP. As I mentioned in my suggestion post, [Utopian bot sorting criteria improvement to prevent no voting](https://steemit.com/@blockchainstudio/utopian-bot-sorting-criteria-improvement-to-prevent-no-voting-for-mid-score-postings), external contributors definitely have disadvantages in the dev category. Hope the review will be more generous, considering this :) Also, please increase 14 day window soon. It's too short for external contributors gather decent commits due to irregular and infrequent merges by POs. (note: eSteem team is quite fast! Thanks a lot!)

### New Feature + Bug Fix
#### Powerdown information + correct effective SP
https://github.com/esteemapp/esteem-surfer/pull/199

- Show the powerdown amount in the SP section


Previously, eSteem Surfer didn't show the powerdown amount in the Steem Power section, and had a wrong effective SP (in terms of voting value) amount due to this.


![](https://user-images.githubusercontent.com/38183982/51994566-fbda3c80-24a8-11e9-9120-68cf7eacb549.png)
> before: powerdown amount wasn't excluded in the effective SP

![](https://user-images.githubusercontent.com/38183982/52006008-fb4e9f80-24c2-11e9-9797-efcd4847e246.png)
> after: powerdown amount is separately shown and excluded from the effective SP

![](https://user-images.githubusercontent.com/38183982/52001124-9bea9280-24b6-11e9-907e-341d25f18db4.png)
> after (sanity check for no powerdown user)


#### Two usual mistakes in the effective SP calculation
- Doesn't exclude powerdown amount (already explained in the above)
- Doesn't take 14th week power down into account
	That is, powerdown can actually takes 14 weeks, and the "powerdown amount" `vesting_withdraw_rate` is the still same, so if you don't consider this case, the effective SP can go negative. That's why you need, `min` function to avoid this situation.

```
      // min needed due to 14th week powerdown: https://github.com/steemit/steem/issues/3237
      const vestingSharesWithdrawal = Math.min(
        parseToken(account.vesting_withdraw_rate),
        (parseToken(account.to_withdraw) - parseToken(account.withdrawn)) /
          100000
      );
```
> https://github.com/economicstudio/esteem-surfer/blob/7e97bbbcb446d325e48980fb6d29afb235f64618/app/components/Account.js#L910

### New Feature
#### Search to eSteem toggle
https://github.com/esteemapp/esteem-surfer/pull/209

Previously, once search something, toggle back to esteem mode was impossible, which was quite annoying if you want to go to someone's blog. Now toggle is supported back and forth.

### Minor Fixes
#### Fix build instruction
https://github.com/esteemapp/esteem-surfer/pull/200

#### Typo
https://github.com/esteemapp/esteem-surfer/pull/195

### Other activities
#### Search Improvement
https://github.com/esteemapp/esteem-surfer/pull/206

While this wasn't merged due to the eSteem team's another implementation plan, I suggested the search improvement

#### Help debugging for voting time problem
https://github.com/esteemapp/esteem-surfer/issues/208

Not just in this issue, but in general I genuinely tried my best to help the team.

#### GitHub Account
https://github.com/economicstudio
๐Ÿ‘  , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , and 40 others
properties (23)
authorblockchainstudio
permlinkesteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io","development","esteem","surfer","busy"],"links":["https://github.com/esteemapp/esteem-surfer","https://steemit.com/utopian-io/@blockchainstudio/busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc","https://steemit.com/@blockchainstudio/utopian-bot-sorting-criteria-improvement-to-prevent-no-voting-for-mid-score-postings","https://github.com/esteemapp/esteem-surfer/pull/199","https://github.com/economicstudio/esteem-surfer/blob/7e97bbbcb446d325e48980fb6d29afb235f64618/app/components/Account.js#L910","https://github.com/esteemapp/esteem-surfer/pull/209","https://github.com/esteemapp/esteem-surfer/pull/200","https://github.com/esteemapp/esteem-surfer/pull/195","https://github.com/esteemapp/esteem-surfer/pull/206","https://github.com/esteemapp/esteem-surfer/issues/208"],"image":["https://user-images.githubusercontent.com/38183982/51994566-fbda3c80-24a8-11e9-9120-68cf7eacb549.png","https://user-images.githubusercontent.com/38183982/52006008-fb4e9f80-24c2-11e9-9797-efcd4847e246.png","https://user-images.githubusercontent.com/38183982/52001124-9bea9280-24b6-11e9-907e-341d25f18db4.png"],"users":["blockchainstudio"]}
created2019-02-07 15:05:06
last_update2019-02-10 14:33:06
depth0
children14
last_payout2019-02-14 15:05:06
cashout_time1969-12-31 23:59:59
total_payout_value10.110 HBD
curator_payout_value3.292 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length3,688
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries
0.
accountutopian.pay
weight500
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,530,382
net_rshares29,557,829,876,658
author_curate_reward""
vote details (104)
@blockchainstudio · (edited)
$0.04
In Korean: ํ•œ๊ตญ๋ถ„์ค‘์— ์“ฐ์‹œ๋Š” ๋ถ„์ด ์•„๋งˆ ๊ฑฐ์˜ ์—†์œผ์‹ค ๊ฒƒ ๊ฐ™์€๋ฐ ๊ตฟ์นด๋ฅด๋งˆ ์ฆ์ธ์ด ์ง„ํ–‰ํ•˜๋Š” eSteem์˜ ๋ฐํƒ‘๋ฒ„์ „์ธ eSteem Surfer ๊ฐœ๋ฐœ ํ•ด์ค€ ๊ฒƒ์— ๊ด€ํ•œ ํฌ์ŠคํŒ…์ž…๋‹ˆ๋‹ค. ๊ณ„์† ํ•ด์™”๋˜ ํŒŒ์›Œ๋‹ค์šด ์ •๋ณด ํ‘œ์‹œ๋ผ๋˜๊ฐ€ ์ž์ž˜ํ•œ ๋ฒ„๊ทธ ์ˆ˜์ •๋“ค์ž…๋‹ˆ๋‹ค.

https://steemit.com/utopian-io/@blockchainstudio/utopian-bot-sorting-criteria-improvement-to-prevent-no-voting-for-mid-score-postings ์—ฌ๊ธฐ์—์„œ๋„ ์„ค๋ช…๋“œ๋ ธ์ง€๋งŒ ์ตœ๊ทผ ์œ ํ† ํ”ผ์•ˆ ํฌ์ŠคํŒ…๋„ ๋ณดํŒ…ํŒŒ์›Œ ๋ฌธ์ œ๋กœ ๋ณดํŒ…์„ ๋‹ค ๋ชป๋ฐ›๊ณ  ์žˆ๋Š” ์‹ค์ •์ž…๋‹ˆ๋‹ค. ํŠนํžˆ dev ์ชฝ์ด ์ œ์ผ ์‹ฌ๊ฐํ•œ ์ƒํ™ฉ์ž…๋‹ˆ๋‹ค. ์ €๊ฐ™์€ ์™ธ๋ถ€ ๊ธฐ์—ฌ์ž๋Š” ๋ฐ˜์˜๋œ์ง€ 14์ผ์ด๋‚ด์˜ ๊ฒƒ๋งŒ ๋‚ผ์ˆ˜์žˆ๊ณ  ๋ฐ˜์˜ ์Šค์ผ€์ฅด์ด ์ œ๊ฐ๊ฐ์ด๋‹ค๋ณด๋‹ˆ ์• ์ดˆ์— ์ž‘์—…์„ ๋ชจ์•„๋‚ด๊ธฐ ํž˜๋“ค์–ด์„œ ๋”๋”์šฑ ๋ถˆ๋ฆฌํ•ด์„œ ์ €๋ฒˆ busy๋„ ๋ณดํŒ…์„ ์ „ํ˜€ ๋ชป๋ฐ›๊ณ  ์ง€๊ธˆ ์ง€๋‚˜๊ฐ‘๋‹ˆ๋‹ค. $30์ •๋„๊ฐ€ ํ—ˆ๊ณต์—ใ… ใ…  ์ €๋ฟ๋งŒ ์•„๋‹ˆ๋ผ ๋ญ ๋ชป๋ฐ›์€ ์‚ฌ๋žŒ์ด ํ•œ๋‘˜์ด ์•„๋‹ˆ์–ด์„œใ… ใ…  ์‚ฌ์‹ค dev๊ฐ€ ๊ธฐ๋ณธ ์นดํ…Œ๊ณ ๋ฆฌ ๋ณด์ƒ์ด ์ƒ๋‹นํžˆ ๋†’์•„์„œ ํ‰๊ท ์ •๋„ ์ ์ˆ˜๋งŒ ๋ฐ›์•„๋„ ๋ณด์ƒ์ด ์ƒ๋‹นํžˆ ๋†’์€๋ฐ ์•„๊น๊ฒŒ ๋˜์—ˆ๋„ค์š”. ์ด๋ฒˆ๊ฒƒ์€ ์‚ด์•„๋‚จ์œผ๋ฉด ์ข‹๊ฒ ์ง€๋งŒ ๊ธฐ๋ณธ์ ์œผ๋กœ ์žฌ๋ฏธ๋กœ ํ•œ๊ฑฐ๊ณ  ๋ณดํŒ…์€ ์ถ”๊ฐ€์ ์ธ ์ฆ๊ฑฐ์›€์ด๋ผ ์‚ฌ์‹ค ํฐ ๊ธฐ๋Œ€๋Š” ์•ˆํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ํ–ฅํ›„ ๋ฉฐ์น  ์‚ฌ๋žŒ๋“ค์ด ์–ผ๋งˆ๋‚˜ ๊ดœ์ฐฎ์€ devํฌ์ŠคํŒ…์„ ์ œ์ถœํ•˜๋А๋ƒ์— ๋”ฐ๋ผ ์šด๋ช…์ด ๊ฐˆ๋ฆด๋“ฏ^^

์ฐธ๊ณ ๋กœ ์ด์ŠคํŒ€์ชฝ์€ ์•ž์œผ๋กœ ํฐ ์ผ ์—†์œผ๋ฉด ์•„๋งˆ ์ถ”๊ฐ€ ์ž‘์—…์„ ์•ˆํ•  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์ด๊ฒŒ ์ข€ ๋Œ€์ถฉ ๋งŒ๋“ ๋ฉด์— ์—†์ง€ ์•Š์•„๋ณด์—ฌ์„œ ์ฝ”๋“œ ์ฝ๊ธฐ๋„ ์ข€ ๋ถˆํŽธํ•˜๊ณ  ๋ณด๋ฉด ๋ณผ์ˆ˜๋ก ๋‹ค ๋œฏ์–ด ๊ณ ์น˜๊ณ  ์‹ถ์–ด์ง€๊ณ  ์ €๋„ ์ œ ๋‚˜๋ฆ„๋Œ€๋กœ์˜ ์ž„ํŒฉํŠธ์— ๋Œ€ํ•œ ๊ธฐ์ค€์ด ์žˆ์–ด์„œ ์ด๊ฑธ ๊ณ ์นœ๋‹ค๊ณ  ๋ช‡๋ช…์ด ์“ฐ๋‚˜ ์ƒ๊ฐํ•˜๋ฉด ๋™๊ธฐ๋ถ€์—ฌ๊ฐ€ ์ž˜ ์•ˆ๋˜๋„ค์š”. busy๋Š” ์ œ๊ฐ€ ์ž‘์—…ํ•˜๋Š” ์ด์œ ๊ฐ€ ๊ทธ๋ž˜๋„ ๋งŽ์€ ์‚ฌ๋žŒ์ด ์“ฐ๊ธฐ ๋•Œ๋ฌธ์ธ๋ฐ ์ด์ŠคํŒ€์€ ์•„์ง ๊ทธ ์ˆ˜์ค€์€ ์•ˆํƒ€๊น๊ฒŒ ์•ˆ๋˜๋„ค์š”.

์ฐธ ๋ช‡๊ฐ€์ง€ ์žฅ์ ๋„ ์žˆ๊ธด ํ•˜๋”๋ผ๊ณ ์š”. ์ผ๋ถ€ ๋ฐ์ดํ„ฐ๋“ค์„ ์ž์ฒด db๋ฅผ ํ™œ์šฉํ•ด์„œ ์ข€ ๋” ๋ณด์—ฌ์ฃผ๋Š” ๊ธฐ๋Šฅ๊ณผ ๊ฒ€์ƒ‰๊ธฐ๋Šฅ์ด ์ข€ ๋” ์ž˜ ๋™์ž‘ํ•ฉ๋‹ˆ๋‹ค. ํ˜น์‹œ ์จ๋ณด์‹ค ๋ถ„๋“ค์€ ์ฐธ๊ณ ํ•˜์„ธ์š”.
๐Ÿ‘  
properties (23)
authorblockchainstudio
permlinkre-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t152103218z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["blockchainstudio"],"links":["https://steemit.com/utopian-io/@blockchainstudio/utopian-bot-sorting-criteria-improvement-to-prevent-no-voting-for-mid-score-postings"],"image":[]}
created2019-02-07 15:18:06
last_update2019-02-07 16:18:00
depth1
children3
last_payout2019-02-14 15:18:06
cashout_time1969-12-31 23:59:59
total_payout_value0.031 HBD
curator_payout_value0.010 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length988
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,530,955
net_rshares86,351,278,841
author_curate_reward""
vote details (1)
@anpigon ·
์ฐจ๋ผ๋ฆฌ busy ์†Œ์Šค๋ฅผ ํฌํŒ…ํ•˜์—ฌ ๋ฐ์Šคํฌํƒ‘(Electron) ๋ฒ„์ „์„ ๋งŒ๋“œ๋Š”๊ฒŒ ๋” ์ข‹์„ ๋“ฏํ•ฉ๋‹ˆ๋‹ค. ใ…Žใ…Ž ์ €๋„ esteem์€ ๋ฒ„๊ทธ๊ฐ€ ๋งŽ์•„์„œ ์‚ฌ์šฉ์„ ์ž˜ ์•ˆํ•˜๊ฒŒ ๋˜๋„ค์š”.
properties (22)
authoranpigon
permlinkre-blockchainstudio-re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190208t020007296z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[],"image":[]}
created2019-02-08 02:00:09
last_update2019-02-08 02:00:09
depth2
children2
last_payout2019-02-15 02:00:09
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length89
author_reputation17,258,940,000,931
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,552,821
net_rshares0
@blockchainstudio · (edited)
์•ˆ๊ทธ๋ž˜๋„ ์ „ ์ด๋ฒˆ์— ์ฒ˜์Œ์œผ๋กœ electron์ด๋ž€ ๊ฒƒ๋„ ์•Œ์•˜์Šต๋‹ˆ๋‹ค^^ ์ด์ŠคํŒ€์€ ๊ทธ๋“ค์˜ ์ฝ”๋“œ๋•Œ๋ฌธ์— ์ €๊นŒ์ง€ ๋ฆฌ๋ทฐ์— ๊ฐ์ ์„ ๋ฐ›์•„์•ผํ•˜๋Š”๊ฒŒ ์–ต์šธใ… ใ…  ์‚ฌ์‹ค ์ œ๊ฐ€ ๊ฐœ๋ฐœ์ž๋„ ์•„๋‹Œ๋ฐ ์•ž์œผ๋กœ ์•„๋งˆ ์ง„์งœ ์•ˆํ•  ๊ฒƒ ๊ฐ™์•„์š”. busy๋‚˜ ๊ฐ€๋” ์ œ๊ฐ€ ํ•„์š”ํ•˜๋ฉด ๊ณ ์ณ๋ณด๊ณ  ํ•  ์ƒ๊ฐ์ž…๋‹ˆ๋‹ค.

์ฐธ ์œ ํ† ํ”ผ์•ˆ์€ ๊ธ€์—๋„ ์จ๋†จ์ง€๋งŒ ์š”์ƒˆ dev์ชฝ์€ ์™„์ „ ๋ ˆ๋“œ์˜ค์…˜์ด ๋˜์–ด์„œ ์ข€ ์•Œ๋ ค์ง„ ์˜ˆ๋น„์ฆ์ธ๋“ค์ด ์ง„ํ–‰ํ•˜๋Š” ํ”„๋กœ์ ํŠธ ์•„๋‹ˆ๋ฉด ๊ฑฐ์˜ ๋ณดํŒ…์„ ๋ชป๋ฐ›๋Š” ์ƒํ™ฉ์— ์ด๋ฅด๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์ด ๊ธ€๋„ ์•„๋งˆ ๋ณดํŒ… ๋ชป๋ฐ›์„๊ฑฐ์—์š”. ๊ทธ๋ž˜๋„ ๊ตฟ์นด๋ฅด๋งˆ๊ฐ€ ๋ณดํŒ…ํ•ด์ฃผ๊ณ  ๊ฐ”๋„ค์š”ใ…Žใ…Ž
๐Ÿ‘  
properties (23)
authorblockchainstudio
permlinkre-anpigon-re-blockchainstudio-re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190208t021304775z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[],"image":[]}
created2019-02-08 02:10:09
last_update2019-02-08 02:11:33
depth3
children1
last_payout2019-02-15 02:10:09
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length275
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,553,165
net_rshares4,371,223,418
author_curate_reward""
vote details (1)
@blockchainstudio ·
$0.03
@๋ฉ˜์…˜ ๋“ฑ๋ก
๐Ÿ‘  
properties (23)
authorblockchainstudio
permlinkre-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190217t195133280z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[],"image":[]}
created2019-02-17 19:51:48
last_update2019-02-17 19:51:48
depth1
children2
last_payout2019-02-24 19:51:48
cashout_time1969-12-31 23:59:59
total_payout_value0.034 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length6
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id80,013,502
net_rshares86,423,764,320
author_curate_reward""
vote details (1)
@steem.apps ·
$0.03
๋ฉ˜์…˜ ๋Œ“๊ธ€ ์•ˆ๋‚ด ์„œ๋น„์Šค๊ฐ€ ๋“ฑ๋ก๋˜์—ˆ์Šต๋‹ˆ๋‹น.
๐Ÿ‘  
properties (23)
authorsteem.apps
permlinkre------------------re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190217t195156641z
categoryutopian-io
json_metadata{"app":"steem.apps/0.1","format":"markdown"}
created2019-02-17 19:51:57
last_update2019-02-17 19:51:57
depth2
children1
last_payout2019-02-24 19:51:57
cashout_time1969-12-31 23:59:59
total_payout_value0.034 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length22
author_reputation7,218,006,883,278
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id80,013,511
net_rshares85,993,333,931
author_curate_reward""
vote details (1)
@blockchainstudio ·
๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. ์•„์ฃผ ์†Œ๋Ÿ‰ ๊ฐ์‚ฌ์˜ ์˜๋ฏธ๋กœ ์ž„๋Œ€ํ–ˆ์Šต๋‹ˆ๋‹ค^^
properties (22)
authorblockchainstudio
permlinkre-steemapps-re------------------re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190217t201038249z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[],"image":[]}
created2019-02-17 20:10:39
last_update2019-02-17 20:10:39
depth3
children0
last_payout2019-02-24 20:10:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length29
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id80,014,243
net_rshares0
@bukio ·
์งฑ์งฑ๋งจ ํ˜ธ์ถœ์— ์‘๋‹ตํ•˜์—ฌ ๋ณดํŒ…ํ•˜์˜€์Šต๋‹ˆ๋‹ค. 
properties (22)
authorbukio
permlinkre-bukio-jjangjjangman-1549552833074
categoryutopian-io
json_metadata"{"tags":["bukio", "jjangjjangman"],"app":"steemer/1.0"}"
created2019-02-07 15:20:33
last_update2019-02-07 15:20:33
depth1
children0
last_payout2019-02-14 15:20:33
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length22
author_reputation11,545,563,591,097
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,531,054
net_rshares0
@gomdory ·
![](https://ipfs.busy.org/ipfs/QmWYYJdd1o71WgoizVh8Q1QmeqfTUSRy8fGRQ7QYFMQZm1)
properties (22)
authorgomdory
permlinkre-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t151911
categoryutopian-io
json_metadata""
created2019-02-07 15:19:12
last_update2019-02-07 15:19:12
depth1
children0
last_payout2019-02-14 15:19:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length78
author_reputation38,104,394,235,725
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,530,997
net_rshares0
@justyy ·
$11.64
Thank you for your contribution @blockchainstudio .  Currently, according to the [Utopian policies and guidelines](https://join.utopian.io/guidelines), the PR has to be in 14 days. And there is no such thing as *external* or *internal* developers regarding the advantages of rewards whatsoever. Each contribution is marked carefully according to the guidelines. And FYI: my last 3 dev contributions were not upvoted due to the voting algorithm as well.

Anyway, good bug fixes and small improvements to the esteemapp. Here are a few comments:

1. some variable names could be more indicating .. rather than *a* , *p*
2. Your `showPowerDown` comparing to a magik date is quite fragile IMO, you may use a better logics e.g.  if the date is in the future then yes.
3. magic constants like `/100000` without explanations are hard for people who don't like math .. 

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-2-2-1-2-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
๐Ÿ‘  , , , , , , , , , , , , , , , , ,
properties (23)
authorjustyy
permlinkre-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t222423269z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"users":["blockchainstudio"],"links":["https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-3-2-2-2-1-2-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2019-02-07 22:24:27
last_update2019-02-07 22:24:27
depth1
children3
last_payout2019-02-14 22:24:27
cashout_time1969-12-31 23:59:59
total_payout_value8.804 HBD
curator_payout_value2.831 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,310
author_reputation280,616,224,641,976
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,546,471
net_rshares24,766,458,704,484
author_curate_reward""
vote details (18)
@blockchainstudio · (edited)
Hi @justyy, thank you for your review. As I wrote in Note, again (as before in Busy's case) as an external contributor, I tried not to change too much. The points that you mentioned were not mine. If possible, I'd appreciate if you could reevaluate the related section, bug I understand even if you don't. I already enjoyed helping them. I understand the policy, so don't worry. Thanks!

ps. actually 3. 100000 is mine. but it's just million that most people expect. Again, if there was some constant definition file (like steem does), then I would have done that way, but there was no such. So for this specific conversion part, I thought it's okay. Still people need to understand the other part (e.g., reward pool) which is also not explained.

ps2.
> "my last 3 dev contributions were not upvoted due to the voting algorithm as well."

I'm sorry to hear that and I know this one will be in danger too :) Thanks!
properties (22)
authorblockchainstudio
permlinkre-justyy-re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t223101756z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["justyy"],"links":["/@justyy"],"image":[]}
created2019-02-07 22:28:06
last_update2019-02-07 22:37:30
depth2
children0
last_payout2019-02-14 22:28:06
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length915
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,546,571
net_rshares0
@blockchainstudio · (edited)
btw, just in case, don't get me wrong. I really appreciate your detailed feedback. I just wanted to explain that those codes are not mine. I also don't like them, but I didn't want to change them as an external contributor to keep consistency unless I really make big changes across the files. And that's my point. I shouldn't be penalized by those things, but it's just my opinion. Thanks a lot again!
properties (22)
authorblockchainstudio
permlinkre-justyy-re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t224557540z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[],"image":[]}
created2019-02-07 22:43:03
last_update2019-02-07 22:44:39
depth2
children0
last_payout2019-02-14 22:43:03
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length402
author_reputation178,988,499,015,921
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,547,019
net_rshares0
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
authorutopian-io
permlinkre-re-blockchainstudio-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t222423269z-20190210t120638z
categoryutopian-io
json_metadata"{"app": "beem/0.20.17"}"
created2019-02-10 12:06:39
last_update2019-02-10 12:06:39
depth2
children0
last_payout2019-02-17 12:06:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length58
author_reputation152,955,367,999,756
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,660,221
net_rshares0
@steem-ua ·
#### Hi @blockchainstudio!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
**Feel free to join our [@steem-ua Discord server](https://discord.gg/KpBNYGz)**
properties (22)
authorsteem-ua
permlinkre-esteem-surfer-powerdown-information-with-the-correct-effective-sp-search-to-esteem-toggle-etc-20190207t224437z
categoryutopian-io
json_metadata"{"app": "beem/0.20.18"}"
created2019-02-07 22:44:39
last_update2019-02-07 22:44:39
depth1
children0
last_payout2019-02-14 22:44:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length295
author_reputation23,214,230,978,060
root_title"eSteem Surfer - powerdown information with the correct effective SP, search to eSteem toggle, etc."
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,547,070
net_rshares0