create account

RE: [beem] one-time private key / wallet compatibility by blockchainstudio

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @favcau/re-blockchainstudio-beem-one-time-private-key-wallet-compatibility-20190312t194619442z

· @blockchainstudio ·
$0.04
Hi @favcau, thank you so much for your very detailed feedback and I'm happy with the score. So don't get me wrong and  I just like to add some comments.

I agree in general with @crokkon that "added this to the library itself (transactionbuilder.py) is not a good idea.", since that file is a sort-of base library (shared with steem-python), so it might be better to be untouched although that's why I also submitted my PR for the official library.

But I actually don't agree with "The implementation (transactionbuilder.py) can potentially break a lot of other things." :) If you can read the code, you can see that it's actually safe, and if it's unsafe, then the existing and related codes have the serious problem. Even if a wrong private key is provided somehow, the error should be handled properly, and of course I've also already checked that.

While I also agree with that it's better to change more high-level files to add this feature, I chose a more easier (but again still safe and legit) way as an external contributor. One lesson I learned from other contributions are if a PR is complicated, then it tends to be ignored :) So that's why I always prefer a very simple fix so that PO can easily know that it's working without a problem :)

But @holger80 is quite active in dev, so maybe more complicated one might have been okay :) I'll change the PR or just close it depending on his response. 

Many thanks everybody!
👍  
properties (23)
authorblockchainstudio
permlinkre-favcau-re-blockchainstudio-beem-one-time-private-key-wallet-compatibility-20190313t015411272z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["favcau","crokkon","holger80"],"links":["/@favcau","/@crokkon","/@holger80"],"image":[]}
created2019-03-13 01:54:12
last_update2019-03-13 01:54:12
depth2
children4
last_payout2019-03-20 01:54:12
cashout_time1969-12-31 23:59:59
total_payout_value0.032 HBD
curator_payout_value0.010 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,434
author_reputation178,988,499,015,921
root_title"[beem] one-time private key / wallet compatibility"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,186,509
net_rshares63,278,060,790
author_curate_reward""
vote details (1)
@crokkon · (edited)
$0.03
properties (23)
authorcrokkon
permlinkre-blockchainstudio-re-favcau-re-blockchainstudio-beem-one-time-private-key-wallet-compatibility-20190313t074807479z
categoryutopian-io
json_metadata"{"app": ""}"
created2019-03-13 07:48:06
last_update2022-09-18 09:51:54
depth3
children3
last_payout2019-03-20 07:48:06
cashout_time1969-12-31 23:59:59
total_payout_value0.026 HBD
curator_payout_value0.008 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1
author_reputation81,214,366,861,104
root_title"[beem] one-time private key / wallet compatibility"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,206,015
net_rshares51,954,020,009
author_curate_reward""
vote details (1)
@blockchainstudio ·
$0.06
Hi @crokkon, thank you so much for your detailed comment and now I understand what you meant and fully agree with you! I misunderstood your comment like you meant the code itself may not work :)

One last comment is of course I also tried to change cli.py and thought it was the right place to change, but you know in that case, I basically need to change every command that may raise the exception, which was too much, so I took the bad design without thinking further :) But you and @holger80 are 100% right in this case. Thank you so much again and I'll close my PR.
👍  
properties (23)
authorblockchainstudio
permlinkre-crokkon-re-blockchainstudio-re-favcau-re-blockchainstudio-beem-one-time-private-key-wallet-compatibility-20190313t104821667z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["crokkon","holger80"],"links":["/@crokkon","/@holger80"],"image":[]}
created2019-03-13 10:48:24
last_update2019-03-13 10:48:24
depth4
children2
last_payout2019-03-20 10:48:24
cashout_time1969-12-31 23:59:59
total_payout_value0.044 HBD
curator_payout_value0.014 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length569
author_reputation178,988,499,015,921
root_title"[beem] one-time private key / wallet compatibility"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,216,342
net_rshares86,671,707,151
author_curate_reward""
vote details (1)
@holger80 · (edited)
$0.03
Are you planing to make a PR in which cli.py is adapted? Please let me know, so that we both do not work for the same changes..
👍  
properties (23)
authorholger80
permlinkholger80-re-blockchainstudio-re-crokkon-re-blockchainstudio-re-favcau-re-blockchainstudio-beem-one-time-private-key-wallet-compatibility-20190313t151006642z
categoryutopian-io
json_metadata{"app":"partiko","client":"android"}
created2019-03-13 15:10:12
last_update2019-03-13 15:12:30
depth5
children1
last_payout2019-03-20 15:10:12
cashout_time1969-12-31 23:59:59
total_payout_value0.024 HBD
curator_payout_value0.008 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length127
author_reputation358,857,509,568,825
root_title"[beem] one-time private key / wallet compatibility"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,233,826
net_rshares49,010,620,985
author_curate_reward""
vote details (1)