create account

RE: Adding SteemConnect to HapRamp Alpha Web App by gregory.latinier

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @singhpratyush/adding-steemconnect-to-hapramp-alpha-web-app

· @gregory.latinier ·
$3.95
Haaa this is nice! Good use of SteemConnect, removing the posting key from localStorage (really good for security :) ), using a PR and ask for reviews great great great.

Let's dig a little.

When doing a PR that modifies your application that much you should provide a test plan. See my next observation, I wonder if your reviewers really did their job completely ;)

https://github.com/hapramp/alpha-web/blob/053805cc037d5986bd9472f23da053eb69a0b4ca/src/components/header/index.js#L16 => What happens if the cookie has expired ?

Is there a reason why you're mixing cookies and localStorage ? Why not using cookies to initialize your redux state ?

https://github.com/hapramp/alpha-web/blob/b3edaa6773e8df033e44a8dbf26ad347dd30e366/src/utils/haprampAPI.js#L98 => ESlint recommend the use of templates (you should add eslint to your project btw, and maybe prettier to go even further)

Ex: 
```
const i = 1;
const data = `a_${i}_b`; // produces a_1_b
```

I see that you use a lot `let` even when you're not reassigning the value. Is there any reason why you're not using `const` ?

Why is there a `fakeLogin` method in the code ? If it's meant for test purposes you should write real tests with `jest` `mocha` `enzyme` or whatever lib you like.

To sum up, it 's a nice addition that really improves your project. Continue in that direction !

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2221214).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)
👍  ,
properties (23)
authorgregory.latinier
permlinkre-singhpratyush-adding-steemconnect-to-hapramp-alpha-web-app-20180611t225806316z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://github.com/hapramp/alpha-web/blob/053805cc037d5986bd9472f23da053eb69a0b4ca/src/components/header/index.js#L16","https://github.com/hapramp/alpha-web/blob/b3edaa6773e8df033e44a8dbf26ad347dd30e366/src/utils/haprampAPI.js#L98","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2221214","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2018-06-11 22:58:09
last_update2018-06-11 22:58:09
depth1
children2
last_payout2018-06-18 22:58:09
cashout_time1969-12-31 23:59:59
total_payout_value2.968 HBD
curator_payout_value0.986 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,835
author_reputation34,278,323,818,021
root_title"Adding SteemConnect to HapRamp Alpha Web App"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,363,516
net_rshares1,524,132,445,769
author_curate_reward""
vote details (2)
@singhpratyush ·
Hi @gregory.latinier!

Thanks for reviewing the submission :)

I'll make sure to use `const`s and `let`s properly.

I was planning to add tests after improving the code structure of the project. I've opened issues for adding ESlint and prettier.

Your comments from the last blog really helped me focus on what's most important. Hoping to keep hearing from you about the project.

Thanks again 😄
properties (22)
authorsinghpratyush
permlinkre-gregorylatinier-re-singhpratyush-adding-steemconnect-to-hapramp-alpha-web-app-20180613t112013922z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"busy","app":"busy/2.4.0"}
created2018-06-13 11:20:15
last_update2018-06-13 11:20:15
depth2
children0
last_payout2018-06-20 11:20:15
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length395
author_reputation7,035,648,262,478
root_title"Adding SteemConnect to HapRamp Alpha Web App"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,570,780
net_rshares0
@utopian-io ·
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

**Contributing on Utopian**
Learn how to contribute on <a href="https://join.utopian.io">our website</a>.

**Want to chat? Join us on Discord https://discord.gg/h52nFrV.**

<a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for Utopian Witness!</a>
properties (22)
authorutopian-io
permlink20180612t105000909z
categoryutopian-io
json_metadata{"tags":["utopian.tip"],"app":"utopian-io"}
created2018-06-12 10:50:00
last_update2018-06-12 10:50:00
depth2
children0
last_payout2018-06-19 10:50:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length416
author_reputation152,955,367,999,756
root_title"Adding SteemConnect to HapRamp Alpha Web App"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,429,191
net_rshares0