create account

SMT hard fork testing report #5 : Emission token unit bug, calling for more support by howo

View this thread on: hive.blogpeakd.comecency.com
· @howo · (edited)
$57.95
SMT hard fork testing report #5 : Emission token unit bug, calling for more support
![](https://cdn.steemitimages.com/DQmYTZUjtKtFvoSGBanjsDZzBmbEy63M1PndHkhqjsvjqH3/image.png)

Hello, 

## Asking for more support

When I started this proposal, I assumed that the smt testing period would last about three months, so I put the end of my proposal in three months, but my proposal is coming to an end and the testing is still ongoing, so I would like to ask for your support on my followup proposal, obviously should the testing end before the end of the proposal, I will cancel the proposal now that it no longer serves a purpose. 

Here's a few easy links to vote on it :

https://steemproposals.com/proposal/70
[steemconnect](https://beta.steemconnect.com/sign/update-proposal-votes?proposal_ids=%5B70%5D&approve=true)

Anyways, onto the report

## The previous bug is still ongoing

The steemit team worked hard and pushed a fix for the previous bug I found, but alas, it came back with another issue linked to it. So the testnet has been restarted with some additional logging so that we can have more insight on how to fix it for good. I have restarted my testnet killer script (source here : https://github.com/drov0/hf23-testing/blob/master/bulk_full_setup.js) and the testnet should crash in the coming days. Hopefully this will be the last time this script works.

## Another issue with the emission operation found

Meanwhile while reading some code I realized that with the emission operation it is possible to set it up so that the chain will emit tokens to an account that doesn't exists.

This wouldn't have any bad effect when the emission object is created, but as soon as the smt launches and the first emission executes itself, the chain won't realize that the account doesn't exists and basically give tokens to a nonexistent account. Which would, as you can expect, would probably crash the network, I didn't put this theory to the test as this would just delay further testing. Chain restarts are quite time consuming. 

The reason why is that it's not an obvious flaw since you can set various emission destinations market, vesting, reward pool and founders. And there is quite a bit of code there in order to support those various destinations.  

## Fixing the issue 

While I was at it and since the steemit team is focused on the other bug, I figured I would to make the fix myself, so I submitted a pull request with the necessary code changes to fix the issue : https://github.com/steemit/steem/pull/3582 

it's working but it's lacking some unit tests. So I'll do some more work on it later on.

## Does this bug has a twin ? 

Doing all this and realizing that the emission target accounts (vesting, reward pool etc etc) system is quite similar for the ICO part, so I've checked it out as well. 

And it looks like it does not have one, as you can see here : https://github.com/steemit/steem/blob/master/libraries/chain/smt_evaluator.cpp#L135

This function calls this other function (https://github.com/steemit/steem/blob/master/libraries/chain/smt_evaluator.cpp#L122) to validate all the targets. 

So all good on that end.

Anyways that's about it for this report. Please consider voting my followup proposal using these links :

https://steemproposals.com/proposal/70
[steemconnect](https://beta.steemconnect.com/sign/update-proposal-votes?proposal_ids=%5B70%5D&approve=true)
👍  , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , and 355 others
👎  , , , , , , , , ,
properties (23)
authorhowo
permlinksmt-hard-fork-testing-report-5-emission-token-unit-bug-calling-for-more-support
categorysmt
json_metadata{"tags":["hf","testing","report","sps","palnet"],"image":["https://cdn.steemitimages.com/DQmYTZUjtKtFvoSGBanjsDZzBmbEy63M1PndHkhqjsvjqH3/image.png"],"links":["https://steemproposals.com/proposal/70","https://beta.steemconnect.com/sign/update-proposal-votes?proposal_ids=%5B70%5D&approve=true","https://github.com/drov0/hf23-testing/blob/master/bulk_full_setup.js","https://github.com/steemit/steem/pull/3582","https://github.com/steemit/steem/blob/master/libraries/chain/smt_evaluator.cpp#L135","https://github.com/steemit/steem/blob/master/libraries/chain/smt_evaluator.cpp#L122"],"app":"steemit/0.1","format":"markdown"}
created2020-01-22 18:43:18
last_update2020-01-22 18:50:30
depth0
children20
last_payout2020-01-29 18:43:18
cashout_time1969-12-31 23:59:59
total_payout_value32.282 HBD
curator_payout_value25.671 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length3,324
author_reputation515,737,941,459,006
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,658,033
net_rshares210,474,622,756,864
author_curate_reward""
vote details (429)
@ae1000 ·
Thanks
properties (22)
authorae1000
permlinkq4k8f4
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-23 12:37:57
last_update2020-01-23 12:37:57
depth1
children0
last_payout2020-01-30 12:37:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length6
author_reputation627,481,465
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,682,823
net_rshares0
@alexanderfluke ·
<sup>Hi, Martin!<br>I apologize for writing here, but I saw that you are one of the founders of the Steempress platform, and I felt it necessary to inform you that with the help of the @steemcleaners, I started the process of downvoting the @abrikoss account which using your plugin to publish meaningless posts with links to other people's content ... I thought you should know about this.<br></sup>
properties (22)
authoralexanderfluke
permlinkre-howo-2020127t184427789z
categorysmt
json_metadata{"tags":["hf","testing","report","sps","palnet"],"app":"esteem/2.2.2-surfer","format":"markdown+html","community":"esteem.app"}
created2020-01-27 13:44:30
last_update2020-01-27 13:44:30
depth1
children0
last_payout2020-02-03 13:44:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length400
author_reputation241,383,688,297,832
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries
0.
accountesteemapp
weight300
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,817,702
net_rshares0
@arcange ·
Congratulations @howo!
Your post was mentioned in the [Steem Hit Parade](/hit-parade/@arcange/daily-hit-parade-20200122) in the following category:

* Pending payout - Ranked 3 with $ 62,32
properties (22)
authorarcange
permlinkre-smt-hard-fork-testing-report-5-emission-token-unit-bug-calling-for-more-support-20200122t164912000z
categorysmt
json_metadata""
created2020-01-23 15:49:45
last_update2020-01-23 15:49:45
depth1
children0
last_payout2020-01-30 15:49:45
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length190
author_reputation1,146,633,668,945,473
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,688,177
net_rshares0
@bala41288 ·
Nice work @howo. Is it possible for you to continue work on this for HMT and bring it to live as soon as possible? 

I think we may not need a Hive Engine if we can get HMT up and running.  Correct me if I'm wrong.
properties (22)
authorbala41288
permlinkq87b15
categorysmt
json_metadata{"users":["howo"],"app":"hiveblog/0.1"}
created2020-04-03 07:19:54
last_update2020-04-03 07:19:54
depth1
children2
last_payout2020-04-10 07:19:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length214
author_reputation1,532,751,732,031,158
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id96,689,158
net_rshares0
@howo ·
Hi, 

SMTs are stil SMTs, the S stands for "smart", Smart Media Tokens. 

I am continuing my work on SMTs, but don't expect them too soon, We will be doing hard fork 24 and there will probably be a few months before smts
properties (22)
authorhowo
permlinkq8blng
categorysmt
json_metadata{"app":"hiveblog/0.1"}
created2020-04-05 14:59:39
last_update2020-04-05 14:59:39
depth2
children1
last_payout2020-04-12 14:59:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length220
author_reputation515,737,941,459,006
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id96,718,775
net_rshares0
@bala41288 ·
Thank you so much for the response. It will be great to see that soon. It will be helpful for all the tribes that are using the sidechain now. 

Good luck with that. 👍🙂
properties (22)
authorbala41288
permlinkre-howo-202045t203329254z
categorysmt
json_metadata{"tags":["esteem"],"app":"esteem/2.2.5-mobile","format":"markdown+html","community":"hive-125125"}
created2020-04-05 15:03:30
last_update2020-04-05 15:03:30
depth3
children0
last_payout2020-04-12 15:03:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length168
author_reputation1,532,751,732,031,158
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries
0.
accountesteemapp
weight300
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id96,718,825
net_rshares0
@bangbang ·
thanks for this blog bro
👎  
properties (23)
authorbangbang
permlinkq4ixak
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-22 19:40:00
last_update2020-01-22 19:40:00
depth1
children0
last_payout2020-01-29 19:40:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length24
author_reputation4,813,108,379
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,659,192
net_rshares-21,739,191
author_curate_reward""
vote details (1)
@cyberblock ·
Nothing worse than an evil twin
👍  
properties (23)
authorcyberblock
permlinkq4j85a
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-22 23:34:24
last_update2020-01-22 23:34:24
depth1
children0
last_payout2020-01-29 23:34:24
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length31
author_reputation26,134,242,075,354
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,664,195
net_rshares597,662,679
author_curate_reward""
vote details (1)
@fedismaoui ·
hello steemit and i hope that you dont spam me , i need some support from you . i m using this website since two years and i couldnt increase my account at all . peace to you all from north africa .
👍  
properties (23)
authorfedismaoui
permlinkq4kfmd
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-23 15:13:27
last_update2020-01-23 15:13:27
depth1
children0
last_payout2020-01-30 15:13:27
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length198
author_reputation177,677,911,222
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,686,749
net_rshares363,323,235
author_curate_reward""
vote details (1)
@freddio ·
$0.04
you have my vote
👍  
properties (23)
authorfreddio
permlinkq4ixue
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-22 19:51:51
last_update2020-01-22 19:51:51
depth1
children1
last_payout2020-01-29 19:51:51
cashout_time1969-12-31 23:59:59
total_payout_value0.022 HBD
curator_payout_value0.022 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length16
author_reputation7,719,090,707,167
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,659,421
net_rshares283,020,640,215
author_curate_reward""
vote details (1)
@howo ·
Thanks :)
👍  
properties (23)
authorhowo
permlinkq4luwt
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-24 09:41:18
last_update2020-01-24 09:41:18
depth2
children0
last_payout2020-01-31 09:41:18
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length9
author_reputation515,737,941,459,006
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,716,376
net_rshares8,080,948,439
author_curate_reward""
vote details (1)
@jaydih ·
$0.05
keep up the good work 👍👍
👍  
properties (23)
authorjaydih
permlinkq4j6qg
categorysmt
json_metadata{"app":"steemit/0.2"}
created2020-01-22 23:03:51
last_update2020-01-22 23:03:51
depth1
children1
last_payout2020-01-29 23:03:51
cashout_time1969-12-31 23:59:59
total_payout_value0.025 HBD
curator_payout_value0.025 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length24
author_reputation160,272,694,389,766
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,663,726
net_rshares312,004,706,138
author_curate_reward""
vote details (1)
@howo · (edited)
Thank you for your continuous support !
properties (22)
authorhowo
permlinkq4luw4
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-24 09:40:54
last_update2020-01-24 09:41:12
depth2
children0
last_payout2020-01-31 09:40:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length39
author_reputation515,737,941,459,006
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,716,367
net_rshares0
@marki99 ·
You have my vote.
properties (22)
authormarki99
permlinkq4krv4
categorysmt
json_metadata{"app":"steemit/0.1"}
created2020-01-23 19:37:54
last_update2020-01-23 19:37:54
depth1
children0
last_payout2020-01-30 19:37:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length17
author_reputation11,400,723,818,181
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,695,755
net_rshares0
@smooth ·
$0.07
This is good work and I am supporting the extension.

Another benefit that Steem gets from funding this work is @howo becoming more familiar with the core Steem code, and can be better prepared to start to help with additional development and testing tasks in the future. Having more people with experience working with the code for Steem is a big deal.
👍  ,
properties (23)
authorsmooth
permlinkq4m05o
categorysmt
json_metadata{"users":["howo"],"app":"steemit/0.1"}
created2020-01-24 11:34:42
last_update2020-01-24 11:34:42
depth1
children0
last_payout2020-01-31 11:34:42
cashout_time1969-12-31 23:59:59
total_payout_value0.065 HBD
curator_payout_value0.009 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length353
author_reputation253,602,537,834,068
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,719,071
net_rshares758,324,162,869
author_curate_reward""
vote details (2)
@steemitboard ·
Congratulations @howo! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :

<table><tr><td><img src="https://steemitimages.com/60x70/http://steemitboard.com/@howo/votes.png?202001280550"></td><td>You distributed more than 36000 upvotes. Your next target is to reach 37000 upvotes.</td></tr>
</table>

<sub>_You can view [your badges on your Steem Board](https://steemitboard.com/@howo) and compare to others on the [Steem Ranking](https://steemitboard.com/ranking/index.php?name=howo)_</sub>
<sub>_If you no longer want to receive notifications, reply to this comment with the word_ `STOP`</sub>



###### [Vote for @Steemitboard as a witness](https://v2.steemconnect.com/sign/account-witness-vote?witness=steemitboard&approve=1) to get one more award and increased upvotes!
properties (22)
authorsteemitboard
permlinksteemitboard-notify-howo-20200128t064817000z
categorysmt
json_metadata{"image":["https://steemitboard.com/img/notify.png"]}
created2020-01-28 06:48:18
last_update2020-01-28 06:48:18
depth1
children0
last_payout2020-02-04 06:48:18
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length834
author_reputation38,975,615,169,260
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,841,304
net_rshares0
@steempeak ·
$0.04
Good job finding those bugs.
👍  
properties (23)
authorsteempeak
permlinkre-howo-q4kgbs
categorysmt
json_metadata{"tags":["smt"],"app":"steempeak/2019.12.0"}
created2020-01-23 15:28:42
last_update2020-01-23 15:28:42
depth1
children3
last_payout2020-01-30 15:28:42
cashout_time1969-12-31 23:59:59
total_payout_value0.018 HBD
curator_payout_value0.018 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length28
author_reputation175,130,396,955,416
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,687,551
net_rshares227,253,910,311
author_curate_reward""
vote details (1)
@howo · (edited)
$0.02
Who forgot to switch accounts ? @jarvie ? :p
👍  
properties (23)
authorhowo
permlinkq4luxz
categorysmt
json_metadata{"users":["jarvie"],"app":"steemit/0.1"}
created2020-01-24 09:42:00
last_update2020-01-24 09:42:15
depth2
children2
last_payout2020-01-31 09:42:00
cashout_time1969-12-31 23:59:59
total_payout_value0.012 HBD
curator_payout_value0.012 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length44
author_reputation515,737,941,459,006
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,716,392
net_rshares152,806,926,142
author_curate_reward""
vote details (1)
@jarvie ·
haha. I thought about it... but @steempeak is also grateful for you helping with the testnet so i didn't see the need to switch. 
properties (22)
authorjarvie
permlinkre-howo-q4lv75
categorysmt
json_metadata{"tags":["smt"],"app":"steempeak/2.2.8"}
created2020-01-24 09:47:36
last_update2020-01-24 09:47:36
depth3
children1
last_payout2020-01-31 09:47:36
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length130
author_reputation388,491,264,112,133
root_title"SMT hard fork testing report #5 : Emission token unit bug, calling for more support"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id94,716,484
net_rshares0