You can see all the code changes here:
https://github.com/steemit/steem/pull/3626/files
All the commits here:
https://github.com/steemit/steem/pull/3626
There are 51 total commits including one from back in September which start March on 16th. I'll go through each one (minus merge commits) and explain them as I understood them when I did my review of the code as a witness before deciding to run v0.23.0. I should point out that I'm not a C++ developer, and I did not write any of this code. Full credit goes to those who worked tirelessly on this effort. As a witness with a development background, I always review code before deploying it and encourage all witnesses to do so or hire someone you trust to do so for you (ideally not an existing consensus witness).
Most of the commits have very descriptive commit messages which do a fairly good job of explaining what's going on. As far as I can tell, it doesn't appear anything malicious was included in this hard fork.
* <a href="https://github.com/steemit/steem/pull/3626/commits/0c5da8e7016739befceb99136d9237ef43e4facf">0c5da8e7016739befceb99136d9237ef43e4facf</a>
<blockquote>
[BW]: Changed STEEM and SBD coin names in the legacy_asset implementation.
[BW]: Renamed get_config parameter names.
[BW]: Eliminated STEEM and SBD names from assertion messages etc.
</blockquote>
Pretty straight forward. Just renames token symbols.
* <a href="https://github.com/steemit/steem/pull/3626/commits/74177d3a7c3a96a7f7e007195e1f5468f0daa9cd">74177d3a7c3a96a7f7e007195e1f5468f0daa9cd</a>
<blockquote>
Remove all delegations and steem/sp/sbd from steemit accounts
</blockquote>
Adds STEEM_HARDFORK_0_23 and starts looping through accounts defined here:
`for (auto account_name : hardforkprotect::get_steemit_accounts()) {`
My understanding of this code includes, for specific accounts, moving their stake to the Hive Proposal treasury account which, as you can see here, is not controlled by anyone but the blockchain code itself (it has no owner or active keys):
This code removes proxy votes, delegations, adjust voting mana, and ultimate adjusts token balances.
The code also prepares things to set a date for the Hard Fork both on the testnet and the mainnet.
* <a href="https://github.com/steemit/steem/pull/3626/commits/1bcf56a7d50f694007d04ad2be9a53f57cb1e2ee">1bcf56a7d50f694007d04ad2be9a53f57cb1e2ee</a>
<blockquote>
transfer escrow, savings to dao. remove pending curation and posting rewards
</blockquote>
More transfers of impacted account funds to the treasury. This included things most people probably don't think about such as escrows and savings balances.
* <a href="https://github.com/steemit/steem/pull/3626/commits/9840b8315c11d2c08d501955d41fd186a04cd592">9840b8315c11d2c08d501955d41fd186a04cd592</a>
<blockquote>
Added support for rewards along with global supply
</blockquote>
As far as I know, this puts pending rewards back into the global supply.
* <a href="https://github.com/steemit/steem/pull/3626/commits/e9f2f7302bbf691c8084383edc85d10f4aee58f9">e9f2f7302bbf691c8084383edc85d10f4aee58f9</a>
<blockquote>
hardfork vop
</blockquote>
I think this adds a virtual operation `hardfork_hive_operation` to actually implement the hard fork changes which move balances around.
* <a href="https://github.com/steemit/steem/pull/3626/commits/1b421e7981f0844dd559790b40f7c508d2d6981b">1b421e7981f0844dd559790b40f7c508d2d6981b</a>
<blockquote>
[BW]: Added possibility to specify hardfork time through env. variable to make testing easier.
[BW]: Witnesses version majority rules are excluded for HF23
</blockquote>
Helps with testing to set the hard fork time to be an environment variable so you don't have to recompile the code each time to test your hard fork changes. As for the second part, that's a bit more tricky.
```
ilog("Forcing HF23 without need to have witness majority version");
```
I asked Blocktrades about this when I was reviewing the code and he gave me permission to share that discussion with you:
*(Note, I've since decided <a href="https://peakd.com/steemisdead/@lukestokes/i-ve-decided-to-shut-down-my-steem-witness">not to run a witness node on Steem</a>)*
This is a little tricky, but as far as I can tell it allows a non-majority group of witnesses (as is the case when the chain is being sybil attacked by 20 sock puppet witnesses so community-supported witnesses are not the majority) to create their own valid fork for this chain id and keep running with it on their own to implement HF 23. For more on the philosophy behind this, see @blocktrades post <a href="https://peakd.com/cryptocurrency/@blocktrades/the-fundamental-underpinning-of-blockchain-consensus">The Fundamental Underpinning of Blockchain Consensus</a>
* <a href="https://github.com/steemit/steem/pull/3626/commits/39db349c7f76c58bc7d54ec46dae6b7669117f8d">39db349c7f76c58bc7d54ec46dae6b7669117f8d</a>
<blockquote>
[BW]: [NIP] Implemented storage for transaction_id inxed in AH-rocksdb version. Also implemented API query to execute get_transaction.
</blockquote>
I think this allows for improvements to account history so individual transaction ids can be indexed and retrieved with find_transaction_info so instead of
```
FC_ASSERT( false, "This API is not supported for account history backed by RocksDB" );
```
We get code to use RocksDB and full history. That's my understanding, at least.
* <a href="https://github.com/steemit/steem/pull/3626/commits/0d662f1bc49dc0e16cf982a19be7059ed5e7c5c9">0d662f1bc49dc0e16cf982a19be7059ed5e7c5c9</a>
<blockquote>
Added escrows to as target as well and fixed vests withdrawal issues
</blockquote>
Looks to be some code fixes relating to escrow and how vested shares are handled on withdrawals.
* <a href="https://github.com/steemit/steem/pull/3626/commits/37b43569ecd1ece086e3c594573e80dfa828ce10">37b43569ecd1ece086e3c594573e80dfa828ce10</a>
<blockquote>
STEEM and SBD rename supplement:
</blockquote>
Dump method added for debugging along with some more descriptive information if the database is created by a different compiler, build, or operating system. Asset symbols HBD_SYMBOL_U64 and HIVE_SYMBOL_U64 added to work along side SBD_SYMBOL_U64 and STEEM_SYMBOL_U64
* <a href="https://github.com/steemit/steem/pull/3626/commits/a368be40a7da294a63c28c1b45309a8413cd0317">a368be40a7da294a63c28c1b45309a8413cd0317</a>
<blockquote>
[ABW]: [Fix] wrong balance affected when removing savings
</blockquote>
minor fix, looks like a copy/paste error.
* <a href="https://github.com/steemit/steem/pull/3626/commits/a341ce4d3fc08fe78288c0147f8247f42b574718">a341ce4d3fc08fe78288c0147f8247f42b574718</a>
<blockquote>
[ABW]: [Fix] it should already be at zero and if it wasn't making it zero like that would break invariants
</blockquote>
minor fix, initializing variables
* <a href="https://github.com/steemit/steem/pull/3626/commits/9a3a42d2dcecf1b5944e57eafb538098a7c5a089">9a3a42d2dcecf1b5944e57eafb538098a7c5a089</a>
<blockquote>
[ABW]: [Fix] reward_vesting_steem is STEEM, not VESTS; also duplicate code
</blockquote>
Appears to be a minor fix as it already has:
```
a.reward_vesting_balance = asset( 0, VESTS_SYMBOL );
a.reward_vesting_steem = asset( 0, STEEM_SYMBOL );
```
* <a href="https://github.com/steemit/steem/pull/3626/commits/074bd5336beb0890ae17c4dc0adf4bb558dddab8">074bd5336beb0890ae17c4dc0adf4bb558dddab8</a>
<blockquote>
[ABW]: [Fix] no need to break historical record of the account
</blockquote>
Looks like without this fix it would have reset curation and posting rewards history to zero. Glad this was fixed so that Hard Fork 23 is more of a continuation of Steem.
* <a href="https://github.com/steemit/steem/pull/3626/commits/3d096d9173bb013c97d41935e713285374f118c6">3d096d9173bb013c97d41935e713285374f118c6</a>
<blockquote>
[ABW]: [Fix] looking for 'to' would require different index that does not exist now (plus we don't need it); missing handling of pending_fee would break invariants
</blockquote>
Looks to be some more fixes for handling escrow balances.
* <a href="https://github.com/steemit/steem/pull/3626/commits/eeabcc71f6192e4cf10a38e8c065c1b6f83325fa">eeabcc71f6192e4cf10a38e8c065c1b6f83325fa</a>
<blockquote>
[ABW]: [Fix] missing clearing of open limit orders
</blockquote>
Ensures if the accounts being cleared out had open orders on the internal market, those orders get cancelled.
* <a href="https://github.com/steemit/steem/pull/3626/commits/1a84fdc541af72e65260b76926cd5fe78b4cb148">1a84fdc541af72e65260b76926cd5fe78b4cb148</a>
<blockquote>
[ABW]: [Fix] missing clearing of pending convert requests
</blockquote>
Same as above but for pending HBD conversions to HIVE and calls adjust_balance as needed to put the HBD back in the account.
* <a href="https://github.com/steemit/steem/pull/3626/commits/6b4a2aa3c74bdd84aebf27cb10cc7b8a89c054d7">6b4a2aa3c74bdd84aebf27cb10cc7b8a89c054d7</a>
<blockquote>
[ABW]: [Ign] minor tweak
</blockquote>
* <a href="https://github.com/steemit/steem/pull/3626/commits/24d2be491e715520d1d56dd6125e5e30bed8719e">24d2be491e715520d1d56dd6125e5e30bed8719e</a>
<blockquote>
[ABW]: [Fix] gpo.total_vesting_shares and gpo.total_vesting_fund_steem (almost) always change in tandem, and always in the same direction
</blockquote>
I'm not entirely sure why it was + before, but this puts it back to a - to update total_vesting_fund_steem just like total_vesting_shares.
* <a href="https://github.com/steemit/steem/pull/3626/commits/3a7d4809ae4b7a09f1f6ab37b2965a0b9a1d7e5f">3a7d4809ae4b7a09f1f6ab37b2965a0b9a1d7e5f</a>
<blockquote>
[ABW]: [Fix] mix of claim_reward_balance_operation and conversion from vests to steem cancel out their influence on gpo.total_*; also avoid actual conversion back and forth
</blockquote>
I'm not entirely sure, but I think this is some fixes to where it converts Steem Power into liquid STEEM for the effected accounts.
* <a href="https://github.com/steemit/steem/pull/3626/commits/64d6e880f81f278b61b0a611c99edb554c966883">64d6e880f81f278b61b0a611c99edb554c966883</a>
<blockquote>
[ABW]: [Fix] unused variable and related code removed; unnecessary operation removed from inside loop (it only needs to be done once before clearing)
</blockquote>
Relates to downvote pool clearing.
* <a href="https://github.com/steemit/steem/pull/3626/commits/d1aba596c87c02a2a3405e64f0c3a084405cbe9c">d1aba596c87c02a2a3405e64f0c3a084405cbe9c</a>
<blockquote>
[ABW]: [Fix] wrong index used - needs two separate runs for 'from' and 'to' to cancel outgoing withdrawals and speedup incoming ones (resulting balance is taken out later)
</blockquote>
Related to savings account withdrawals.
* <a href="https://github.com/steemit/steem/pull/3626/commits/b6f4d1fb9a9d6197f0726d716ed127669a67871d">b6f4d1fb9a9d6197f0726d716ed127669a67871d</a>
<blockquote>
[ABW]: [Ign] formatting
</blockquote>
* <a href="https://github.com/steemit/steem/pull/3626/commits/929b67da33bedb1f8a9c3179ff9a65a2f7346069">929b67da33bedb1f8a9c3179ff9a65a2f7346069</a>
<blockquote>
[ABW]: [Fix] missing handling of expired delegation objects; also loop on delegations simplified
</blockquote>
Looks like some code refactoring along with ensure expired delegations are properly managed in the hard fork.
* <a href="https://github.com/steemit/steem/pull/3626/commits/d0bc5c2ca6f09642b95209bc6750c27f35a4e7eb">d0bc5c2ca6f09642b95209bc6750c27f35a4e7eb</a>
<blockquote>
Reset TAPOS buffer to avoid replay attack
</blockquote>
I think this is an important one to ensure both chains operate independently even though they have the same chain id and to ensure someone could not do a double spend right as the fork was happening. TAPOS stands for transaction as proof of stake.
* <a href="https://github.com/steemit/steem/pull/3626/commits/3c761638526bc1d45a9171e24029b140ef2bf489">3c761638526bc1d45a9171e24029b140ef2bf489</a>
<blockquote>
init default values for SBD asset with proper symbol
</blockquote>
Minor initialization fix.
* <a href="https://github.com/steemit/steem/pull/3626/commits/713fdc6f46407b875406520f2f95ac41f4e745b4">713fdc6f46407b875406520f2f95ac41f4e745b4</a>
<blockquote>
[ABW]: [Ign] code for HF23 moved to separate routine for easier testing
</blockquote>
Code refactoring
* <a href="https://github.com/steemit/steem/pull/3626/commits/60e81a3dcc61f5fec59fcebd9057e1e5b101766b">60e81a3dcc61f5fec59fcebd9057e1e5b101766b</a>
<blockquote>
First HF unit-test - doesn't work
</blockquote>
Testing, hurray!
* <a href="https://github.com/steemit/steem/pull/3626/commits/d01fc9d181f67adc58b256a0ef0f687fbc3f2737">d01fc9d181f67adc58b256a0ef0f687fbc3f2737</a>
<blockquote>
[BW]: HF23 time can be specified via env. variable also for MainNet
[BW]: Changing default HF23 time to quite far future (April 8.)
</blockquote>
More tweaks to the HF time.
* <a href="https://github.com/steemit/steem/pull/3626/commits/03478f6c446815edcbee8ef3d37c5cb60580d223">03478f6c446815edcbee8ef3d37c5cb60580d223</a>
<blockquote>
The simplest unit-test works
</blockquote>
More testing, more hurray!
* <a href="https://github.com/steemit/steem/pull/3626/commits/3cb9b67e767b1fec19f7480cca77c6ddb0c08639">3cb9b67e767b1fec19f7480cca77c6ddb0c08639</a>
<blockquote>
Voting + delegations - unit-tests part 1
</blockquote>
Even more testing, even more hurray!
* <a href="https://github.com/steemit/steem/pull/3626/commits/8b2ba15160f6985f13995abce70993caf944927d">8b2ba15160f6985f13995abce70993caf944927d</a>
<blockquote>
Voting + delegations - unit-tests part 2
</blockquote>
We like tests! Tests keep blockchains from breaking. :)
* <a href="https://github.com/steemit/steem/pull/3626/commits/5027f29ee6ee4b917775123b683c23ed6a16b1dc">5027f29ee6ee4b917775123b683c23ed6a16b1dc</a>
<blockquote>
[BW]: [HF23 time set to Friday, 20 March 2020 14:00:00 GMT
</blockquote>
* <a href="https://github.com/steemit/steem/pull/3626/commits/98ff1a584b372dcf289994f8b5bbc24783c1d0f4">98ff1a584b372dcf289994f8b5bbc24783c1d0f4</a>
<blockquote>
[BW]: Fixed compile failure in TEST_NET build
</blockquote>
* <a href="https://github.com/steemit/steem/pull/3626/commits/ad3414d7d02dc4d570165e65051a81d4906bb49a">ad3414d7d02dc4d570165e65051a81d4906bb49a</a>
<blockquote>
Signal HF23 sooner
</blockquote>
This lets people show they are moving to 0.23.0 prior to the hard fork time.
* <a href="https://github.com/steemit/steem/pull/3626/commits/4fe70ee52ada52bca99cd72fa87eca73553b6f3b">4fe70ee52ada52bca99cd72fa87eca73553b6f3b</a>
<blockquote>
changed Steem Network to Hive NW and added ASCII logo
</blockquote>
Updating the start up messages with some cool ascii.
* <a href="https://github.com/steemit/steem/pull/3626/commits/fcf74915950b4546a7abca1836ddf4134e7bb5db">fcf74915950b4546a7abca1836ddf4134e7bb5db</a>
<blockquote>
Exclude accounts who voted a minimum of two sockpuppets and who didn't unvote before the hive announcement with more than 1k sp
</blockquote>
This is where the account list was updated based on a script that was run. There have been reports of errors with how this list was calculated which is what I believe the dev team will be working on next to resolve. If you were negatively impacted by this, please reach out to the developers involved.
* <a href="https://github.com/steemit/steem/pull/3626/commits/2b8f66f5b49b3a446b386ca4abf1e0ff88d06483">2b8f66f5b49b3a446b386ca4abf1e0ff88d06483</a>
<blockquote>
remove last comma
</blockquote>
Minor tweak to account list
* <a href="https://github.com/steemit/steem/pull/3626/commits/86ec9f1716744cf708b703981834e83428d447cb">86ec9f1716744cf708b703981834e83428d447cb</a>
<blockquote>
added sockpuppets
</blockquote>
This adds the Steemit controlled sock puppet accounts.
--------
And that's it!
I don't know how helpful this was for most people as everything is right there on GitHub anyway, but hopefully it's useful to some to know there are witnesses who look over all code changes in detail before deploying them. To me, this is a base requirement for a witness, otherwise they are running a protocol version that entirely trusts whoever developed the code and aren't really adding their own individual validation to the process.
--------
<img src="https://steemitimages.com/DQmR3hhPtgcqhNDZyArucp2dZv2pG62WDKiWam8jrppCXNB/on_a_log_cropped.png">
<p>
<div class="pull-right">
<a href="https://steemit.com/introduceyourself/@lukestokes/my-name-is-luke-let-s-create-the-world-we-want-to-live-in"><img src="https://steemitimages.com/DQmRh7DLpp1hDKugxyWxdDof7rkj5fpBus6tECvv7vcmL6d/smile.png" /></a>
</div>
<sub><a href="https://steemit.com/introduceyourself/@lukestokes/my-name-is-luke-let-s-create-the-world-we-want-to-live-in">Luke Stokes</a> is the Managing Director for the Foundation for Interwallet Operability as well as the Interim Executive Director for the EOS Foundation. He's passionate about voluntary systems of governance and has been involved in bitcoin since early 2013. He's been a witness for the Steem blockchain since early 2018 and a custodian for eosDAC, a community-owned EOSIO Block Producer and DAC Enabler, since its inception. With a computer science degree from UPENN, he built, bootstrapped and co-founded the shopping cart software company FoxyCart over a ten year period and is now focused on blockchain technology as a means to create a world we all want to live in. He currently lives in Puerto Rico with his wife and three children and enjoys discussing everything from philosophy, to consciousness, to voluntaryism, to love and awakening. <a href="https://lukestokes.info">lukestokes.info</a>
<a href="http://understandingblockchainfreedom.com/">UnderstandingBlockchainFreedom.com</a> <a href="https://fio.foundation/">fio.foundation</a> <a href="https://eosdac.io/">eosdac.io</a></sub>
</p>
<center><a href="http://steemitboard.com/board.html?user=lukestokes"><img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/commented.png?v=20191115"> <img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/votes.png?v=20191115"> <img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/posts.png?v=20191115"><img src="https://steemitimages.com/80x65/http://steemitboard.com/@lukestokes/level.png?v=20191115"> <img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/comments.png?v=20191115"> <img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/voted.png?v=20191115"> <img src="https://steemitimages.com/50x55/http://steemitboard.com/@lukestokes/payout.png?v=20191115"></a></center>
<center><sub><a href="https://peakd.com/witness-category/@lukestokes/vote-luke-stokes-for-witness-as-lukestokes-mhth">I'm a Witness</a>! Please <a href="https://peakd.com/me/witnesses">vote for @lukestokes.mhth</a></sub></center><center><a href="https://peakd.com/~witnesses" alt="Please vote for @lukestokes.mhth"><img src="https://cdn.steemitimages.com/DQmUaa1FhpjEtem7LxCEEXfWeqHCUeooUc23MAo8WDCTYZC/image.png"></a></center>
hiveblocks