create account

Steemnova - error message on friend request by mwfiae

View this thread on: hive.blog |  peakd.com |  ecency.com
utopian-io · @mwfiae · (edited)
$18.26
Steemnova - error message on friend request
#### Expected behavior
It should be possible to send friend requests to other players independent of the users language. A website should never display technical error messages to the users. (Even though it helped me find the bug in this case.)

#### Actual behavior
The backend returns an error saying that the language variable is not defined. Making it impossible to send a friend request to an user with another language.

#### How to reproduce
1. Open [Steemnova](https://steemnova.intinte.org)
2. login
3. go to the statistics page
4. find a user from another country
5. try to send a friend request to the user 

(I'm german, if somebody wants to test it out )

#### Recording Of The Bug
![image.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1518569080/zpf5towrosw5wiwzuura.png)

#### Suggested Fix
In [this line](https://github.com/steemnova/steemnova/blob/master/includes/pages/game/ShowBuddyListPage.class.php#L122) 

```$Friend_LNG = new Language($language);``` 

should be replaced with 

```$Friend_LNG = new Language($row['lang']);``` 

Also it should be considered to disable the debug error messages

<br /><hr/><em>Posted on <a href="https://utopian.io/utopian-io/@mwfiae/steemnova-error-message-on-friend-request">Utopian.io -  Rewarding Open Source Contributors</a></em><hr/>
👍  , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , and 81 others
properties (23)
authormwfiae
permlinksteemnova-error-message-on-friend-request
categoryutopian-io
json_metadata"{"community":"utopian","app":"utopian/1.0.0","format":"markdown","repository":{"id":118179003,"name":"steemnova","full_name":"steemnova/steemnova","html_url":"https://github.com/steemnova/steemnova","fork":false,"owner":{"login":"steemnova"}},"pullRequests":[],"platform":"github","type":"bug-hunting","tags":["utopian-io","steemnova","bugreport","friendrequest","php"],"links":["https://steemnova.intinte.org","https://res.cloudinary.com/hpiynhbhq/image/upload/v1518569080/zpf5towrosw5wiwzuura.png","https://github.com/steemnova/steemnova/blob/master/includes/pages/game/ShowBuddyListPage.class.php#L122"],"image":["https://res.cloudinary.com/hpiynhbhq/image/upload/v1518569080/zpf5towrosw5wiwzuura.png"],"moderator":{"account":"sachincool","time":"2018-02-15T19:19:51.887Z","reviewed":true,"pending":false,"flagged":false},"questions":[],"score":0,"issue":{"url":"https://github.com/steemnova/steemnova/issues/29","number":29,"id":297565245,"title":"Steemnova - error message on friend request"}}"
created2018-02-14 01:02:15
last_update2018-02-15 19:19:51
depth0
children10
last_payout2018-02-21 01:02:15
cashout_time1969-12-31 23:59:59
total_payout_value13.149 HBD
curator_payout_value5.109 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,305
author_reputation8,649,692,852,318
root_title"Steemnova - error message on friend request"
beneficiaries
0.
accountutopian.pay
weight2,500
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,343,547
net_rshares3,219,624,337,549
author_curate_reward""
vote details (145)
@minnowsupport · 
<p>Congratulations!  This post has been upvoted from the communal account, @minnowsupport, by MWFIAE from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, theprophet0, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows.  Please find us at the <a href="https://discord.gg/HYj4yvw"> Peace, Abundance, and Liberty Network (PALnet) Discord Channel</a>.  It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.</p> <p>If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=102530.639667%20VESTS">50SP</a>, <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=205303.639667%20VESTS">100SP</a>, <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=514303.639667%20VESTS">250SP</a>, <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=1025303.639667%20VESTS">500SP</a>, <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=2053030.639667%20VESTS">1000SP</a>, <a href="https://v2.steemconnect.com/sign/delegateVestingShares?delegator=&amp;delegatee=minnowsupport&amp;vesting_shares=10253030.639667%20VESTS">5000SP</a>. <br><strong>Be sure to leave at least 50SP undelegated on your account.</strong></p>
properties (22)
authorminnowsupport
permlinkre-steemnova-error-message-on-friend-request-20180214t203447
categoryutopian-io
json_metadata""
created2018-02-14 20:34:48
last_update2018-02-14 20:34:48
depth1
children0
last_payout2018-02-21 20:34:48
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,702
author_reputation148,902,805,319,183
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,566,814
net_rshares0
@mys · 
Nice bug description and quick fixes. Should update the game soon.
Good job!
properties (22)
authormys
permlinkre-mwfiae-steemnova-error-message-on-friend-request-20180214t102459874z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-02-14 10:22:12
last_update2018-02-14 10:22:12
depth1
children1
last_payout2018-02-21 10:22:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length76
author_reputation14,948,575,541,320
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,446,086
net_rshares0
@mwfiae ·
$0.02
Thank you! :)

Fun fact: I found the bug while trying to send a friend request to you  (maybe you saw it in the screenshot). With the message that I hope that I can support the project further in the future! :D
👍  
properties (23)
authormwfiae
permlinkre-mys-re-mwfiae-steemnova-error-message-on-friend-request-20180214t104553885z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-02-14 10:45:54
last_update2018-02-14 10:45:54
depth2
children0
last_payout2018-02-21 10:45:54
cashout_time1969-12-31 23:59:59
total_payout_value0.016 HBD
curator_payout_value0.004 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length210
author_reputation8,649,692,852,318
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,450,684
net_rshares3,015,354,750
author_curate_reward""
vote details (1)
@rocketboost · 
i hope that you do know that utopia is taking 25% of your rewards 
look at your post in steemd.com and check for beneficiaries	
0.	
account	utopian.pay
weight	2,500

that is 25% of the authors rewards , that is a lot of money for some  software
properties (22)
authorrocketboost
permlinkre-mwfiae-steemnova-error-message-on-friend-request-20180216t191216950z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-02-16 19:12:15
last_update2018-02-16 19:12:15
depth1
children1
last_payout2018-02-23 19:12:15
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length244
author_reputation6,801,365,437
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id38,073,978
net_rshares0
@mwfiae · 
I hope that you know that utopian is upvoting with a massive value!
So more than 75% of my rewards are from utopian itself ;) 
[![](https://steemitimages.com/DQmQacuHdkbEQEDJAzduNxa3x7XG8TfkHADv8w65DnJHPyv/image.png)](https://steemitimages.com/DQmQacuHdkbEQEDJAzduNxa3x7XG8TfkHADv8w65DnJHPyv/image.png)

Also its not only software, the money goes to the moderators, etc. 
They do an amazing job and deserve some rewards!
properties (22)
authormwfiae
permlinkre-rocketboost-re-mwfiae-steemnova-error-message-on-friend-request-20180216t191652592z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"image":["https://steemitimages.com/DQmQacuHdkbEQEDJAzduNxa3x7XG8TfkHADv8w65DnJHPyv/image.png"],"links":["https://steemitimages.com/DQmQacuHdkbEQEDJAzduNxa3x7XG8TfkHADv8w65DnJHPyv/image.png"],"app":"steemit/0.1"}
created2018-02-16 19:16:54
last_update2018-02-16 19:16:54
depth2
children0
last_payout2018-02-23 19:16:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length420
author_reputation8,649,692,852,318
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id38,074,860
net_rshares0
@sachincool ·
$0.13
Thank you for the contribution. It has been approved.
Awsome i like your post it follows our rules, Thanks for contributing and sorry for the delay.
You can contact us on [Discord](https://discord.gg/uTyJkNm).
**[[utopian-moderator]](https://utopian.io/moderators)**
👍  ,
properties (23)
authorsachincool
permlinkre-mwfiae-steemnova-error-message-on-friend-request-20180215t192018621z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2018-02-15 19:20:18
last_update2018-02-15 19:20:18
depth1
children1
last_payout2018-02-22 19:20:18
cashout_time1969-12-31 23:59:59
total_payout_value0.120 HBD
curator_payout_value0.007 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length266
author_reputation18,548,631,010,973
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,817,112
net_rshares20,649,945,444
author_curate_reward""
vote details (2)
@mwfiae ·
$0.03
Thank you for your work! :)
No Problem :)

Greetings, 
Martin
👍  
properties (23)
authormwfiae
permlinkre-sachincool-re-mwfiae-steemnova-error-message-on-friend-request-20180215t202209425z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-02-15 20:22:12
last_update2018-02-15 20:22:12
depth2
children0
last_payout2018-02-22 20:22:12
cashout_time1969-12-31 23:59:59
total_payout_value0.022 HBD
curator_payout_value0.007 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length61
author_reputation8,649,692,852,318
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,828,430
net_rshares5,224,969,265
author_curate_reward""
vote details (1)
@steemitstats · 
@mwfiae, No matter approved or not, I upvote and support you.
properties (22)
authorsteemitstats
permlink20180214t011508645z-post
categoryutopian-io
json_metadata{"tags":["utopian-io"]}
created2018-02-14 01:15:27
last_update2018-02-14 01:15:27
depth1
children0
last_payout2018-02-21 01:15:27
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length61
author_reputation351,882,871,185
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,345,745
net_rshares0
@utopian-1up · 
<div class="pull-left">

![1UP-Kayrex_tiny.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1515383984/ekyf2thxg7j2t0qro1h3.png)

</div>

<div class="text-justify">


### You've got upvoted by <code>Utopian-1UP</code>!
You can give up to ten [1UP](https://steemit.com/utopian-io/@steem-plus/steemplus-2-4-utopian-1up-is-here)'s to Utopian posts every day after they are accepted by a Utopian moderator and before they are upvoted by the official @utopian-io account. Install the @steem-plus browser extension to use 1UP. By following the 1UP-trail using [SteemAuto](https://steemauto.com/) you support great Utopian authors and earn high curation rewards at the same time. 

<hr>

1UP is neither organized nor endorsed by Utopian.io!

</div>
properties (22)
authorutopian-1up
permlink20180215t212824578z
categoryutopian-io
json_metadata{"app":"1up"}
created2018-02-15 21:28:24
last_update2018-02-15 21:28:24
depth1
children0
last_payout2018-02-22 21:28:24
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length764
author_reputation2,324,758,056,093
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id37,839,959
net_rshares0
@utopian-io · 
### Hey @mwfiae I am @utopian-io. I have just upvoted you!
#### Achievements
- WOW WOW WOW People loved what you did here. GREAT JOB!
- You have less than 500 followers. Just gave you a gift to help you succeed!
- Seems like you contribute quite often. AMAZING!
#### Suggestions
- Contribute more often to get higher and higher rewards. I wish to see you often!
- Work on your followers to increase the votes/rewards. I follow what humans do and my vote is mainly based on that. Good luck!
#### Get Noticed!
- Did you know project owners can manually vote with their own voting power or by voting power delegated to their projects? Ask the project owner to review your contributions!
#### Community-Driven Witness!
I am the first and only Steem Community-Driven Witness. <a href="https://discord.gg/zTrEMqB">Participate on Discord</a>. Lets GROW TOGETHER!
- <a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for my Witness With SteemConnect</a>
- <a href="https://v2.steemconnect.com/sign/account-witness-proxy?proxy=utopian-io&approve=1">Proxy vote to Utopian Witness with SteemConnect</a>
- Or vote/proxy on <a href="https://steemit.com/~witnesses">Steemit Witnesses</a>

[![mooncryption-utopian-witness-gif](https://steemitimages.com/DQmYPUuQRptAqNBCQRwQjKWAqWU3zJkL3RXVUtEKVury8up/mooncryption-s-utopian-io-witness-gif.gif)](https://steemit.com/~witnesses)

**Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x**
properties (22)
authorutopian-io
permlinkre-mwfiae-steemnova-error-message-on-friend-request-20180217t133548600z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2018-02-17 13:35:48
last_update2018-02-17 13:35:48
depth1
children0
last_payout2018-02-24 13:35:48
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,561
author_reputation152,955,367,999,756
root_title"Steemnova - error message on friend request"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id38,259,432
net_rshares0
Help/Feedback