Every person is an individual, every situation is unique, and what might be great advice for one relationship, might prove to be the worst possible advice for the next.

I do agree with your advice to be honest from the start.  Too few people are really honest in their relationships, which is why so many marriages end in divorce.  No one likes being lied to, least of all by the person we should be able to trust the most, and yeah, lying, including not disclosing something important, is usually a dealbreaker.

It is also a good idea to ask for what you want, out loud and in person, as if your partner doesn't want the same things out of life and/or your relationship,  it is best to know that as soon as possible. 

Too many people of both genders try to "figure out" what their partner is thinking, rather than being honest enough to simply ask, which leads to a huge number of completely avoidable misunderstandings.  

Which, right there, is an indication of potential long-term problems.  If you're not confident enough in your relationship to even ask, then the relationship is doomed from the start.

The bottom line in any relationship is to accept one another as you really are.  Anything less is not going to last, as trying to change one another is a sure recipe for disaster, and destined to fail. 

The only person you can change - the only person you have the right to try and change - is yourself.  If you need to change your partner to be happy, then move on, because it won't work, and will result only in resentment. 

Be the kind of person you would want to be with, be honorable, trustworthy and kind, and your true partner will come into your life.  But be patient, and don't just jump into just any relationship, or you'll miss the right person when they appear.

As for your friend, only she can answer as to what she should do.  But if her long time partner is advising her to move on, she should accept that he is unlikely to change that stance.  If he was deeply in love with her, and really thought they had a long term future together, he wouldn't have suggested she find someone else.

Hello! I find your post valuable for the wafrica community! Thanks for the great post! @wafrica is now following you! ALWAYs follow @wafrica and use the wafrica tag!