create account

Finally Comments - Guest Posting & improvements by sambillingham

View this thread on: hive.blogpeakd.comecency.com
· @sambillingham · (edited)
$182.96
Finally Comments - Guest Posting & improvements
![v-08.jpg](https://gateway.ipfs.io/ipfs/QmX8wqyVxbeNgp4rAbLsK3YmtFmHeEzhcR78Wir6RWb1PC)

# Finally Comments V0.8.x

#### Repository
https://github.com/code-with-sam/finallycomments
    
### New Features
This update being Guest commenting and the needed infrastructure changes to make it work. The majority of the update was around [PR15](https://github.com/code-with-sam/finallycomments/pull/15) with a few extra updates added in additional PRs.

On previous versions of Finally, click ‘Reply’ before having signed in would show a notification saying ‘Please Sign in’, now the user is shown the usual comment box but has the option to ‘Post as Guest’ or Sign in. 

![guestPost](https://gateway.ipfs.io/ipfs/QmabDVqP7Fx1FvhAKiYPEtHdJvGyi4jwpbXMaYiCvpJzRf)
<center>*Guest posting UI*</center>

The process for adding Guest comments was a little more involved than I initially expected. Finally uses the STEEM blockchain as it’s data layer, pull information directly from the blockchain. Guest comments cause an issue because the exact purpose is to not need an account on the Blockchain. 

Guest comments are stored separately in a database but still need to be attached in the comments thread. Guest comments also cannot be voted/earn rewards. I had previously not anticipated that when a STEEM authenticated user replies to a Guest, this can also not(at-least not in the traditional way) be stored on the blockchain. These different scenarios created three districted types of comments. STEEM Comments, Guest Comments and  STEEM REPLY TO GUEST (these have STEEM User information but still can’t be voted).

STEEM comments - stored on the blockhcain and remain unchanged.
Guest Comments & STEEM REPLY TO GUEST - needed there own data models, routes, AJAX response and modified templates. 

- [Guest UI](https://github.com/code-with-sam/finallycomments/pull/15/commits/bf0cc3451514c380b087f40a6f9a9868d16730f3)
- [New AJAX routes etc](https://github.com/code-with-sam/finallycomments/pull/15/commits/1e26b03348d57bf1d1ab32bc08e7952898b22f40)
- [Query new DB](https://github.com/code-with-sam/finallycomments/pull/15/commits/39430eea1f9370a55cf6c0e6425a37a3b0e6e717)
- [Append comments after AJAX success ](https://github.com/code-with-sam/finallycomments/pull/15/commits/52924373ef001f836fdfcb88261e4de083efec96)
- [multi use comment template](https://github.com/code-with-sam/finallycomments/pull/15/commits/0092be30db8e8b88ec945e90dac7a09985cceb70)
Additional commits in full PR

![thread](https://gateway.ipfs.io/ipfs/QmbGx1VoSVG6bV2UpfPrWSgYF4UXYB9h7Wq24ZHqp4ewEo)
<center>*Thread that includes a guest comment*</center>
User interface for Guest comments is kept as minimal as possible to provided a seamless comment system. 

There is potential to store guest comments on the blockchain. Finally comments could broadcast ‘custom_json’ operations for each guest comment. @finallycomments or new account e.g @finallycomments-guest? could post on behalf of the guest. Both have limitations when Finally needs to scale but potentially worth thinking about.

I realised with this The next update needs to be Flagging and or moderation! I’ll work to add this in the next update to give authors more control over what is seen on FinallyComments embed.

### Bug Fixes & Improvements
Finally was initially called steemcomments.js and worked by using hardcoded steemconnect signing links. Some of the namespaces and decisions from that have been hanging around. I’ve started to cut some code and refract in [PR18](https://github.com/code-with-sam/finallycomments/pull/18) but it will require further work to bring it up to standard.

[PR19](https://github.com/code-with-sam/finallycomments/pull/19) fixed a small sign-in but caused by the guest comment UI. The button was added dynamically and events needed to be attached correctly.

### Ideas and contributions 
Last week I post a [roadmap for finally](https://steemit.com/finallycomments/@sambillingham/finally-comments-is-now-on-steemprojects-com). If you’re interested in the development please take a look at that.

Feedback is always welcome, please let me know if you have thoughts on the Guest Comments feature.


#### Proof of Work Done
https://github.com/sambillingham

- MAIN PR - [finallycomments/pull/15
](https://github.com/code-with-sam/finallycomments/pull/15)
- Additional PR2 - [finallycomments/pull/18
](https://github.com/code-with-sam/finallycomments/pull/18)
- Additional PR2 - [finallycomments/pull/19
](https://github.com/code-with-sam/finallycomments/pull/19)

👍  , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , and 20 others
👎  
properties (23)
authorsambillingham
permlinkfinally-comments-guest-posting-and-improvements
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.4.0","format":"markdown","users":["finallycomments","finallycomments-guest","sambillingham"],"links":["https://github.com/code-with-sam/finallycomments","https://github.com/code-with-sam/finallycomments/pull/15","https://github.com/code-with-sam/finallycomments/pull/15/commits/bf0cc3451514c380b087f40a6f9a9868d16730f3","https://github.com/code-with-sam/finallycomments/pull/15/commits/1e26b03348d57bf1d1ab32bc08e7952898b22f40","https://github.com/code-with-sam/finallycomments/pull/15/commits/39430eea1f9370a55cf6c0e6425a37a3b0e6e717","https://github.com/code-with-sam/finallycomments/pull/15/commits/52924373ef001f836fdfcb88261e4de083efec96","https://github.com/code-with-sam/finallycomments/pull/15/commits/0092be30db8e8b88ec945e90dac7a09985cceb70","/@finallycomments","https://github.com/code-with-sam/finallycomments/pull/18","https://github.com/code-with-sam/finallycomments/pull/19"],"tags":["utopian-io","development","busy","finallycomments","steemdev"]}
created2018-05-07 16:38:42
last_update2018-05-07 16:41:21
depth0
children12
last_payout2018-05-14 16:38:42
cashout_time1969-12-31 23:59:59
total_payout_value140.662 HBD
curator_payout_value42.297 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length4,531
author_reputation34,876,406,478,004
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,412,568
net_rshares39,696,978,717,954
author_curate_reward""
vote details (85)
@ackza ·
$0.12
Any progress on this @sambillingham ? We need disqus for steem
👍  ,
properties (23)
authorackza
permlinkre-sambillingham-finally-comments-guest-posting-and-improvements-20190228t213147918z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"users":["sambillingham"],"app":"steemit/0.1"}
created2019-02-28 21:31:51
last_update2019-02-28 21:31:51
depth1
children1
last_payout2019-03-07 21:31:51
cashout_time1969-12-31 23:59:59
total_payout_value0.088 HBD
curator_payout_value0.029 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length62
author_reputation287,776,574,693,472
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id80,553,129
net_rshares195,383,840,163
author_curate_reward""
vote details (2)
@sambillingham ·
$0.10
Been taking a break from posting/open source to focus on freelance. Unfortunately not enough support from the community. Hope to get back to working on this when I can.
👍  ,
properties (23)
authorsambillingham
permlinkre-ackza-re-sambillingham-finally-comments-guest-posting-and-improvements-20190316t145555871z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2019-03-16 14:55:57
last_update2019-03-16 14:55:57
depth2
children0
last_payout2019-03-23 14:55:57
cashout_time1969-12-31 23:59:59
total_payout_value0.072 HBD
curator_payout_value0.023 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length168
author_reputation34,876,406,478,004
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,412,147
net_rshares141,523,671,864
author_curate_reward""
vote details (2)
@azmielbanjary ·
this great project, because steemit as an inclusive platform which audiences can only interaction if they as steemit member.
properties (22)
authorazmielbanjary
permlinkre-sambillingham-finally-comments-guest-posting-and-improvements-20180507t235105985z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"busy","app":"busy/2.4.0"}
created2018-05-07 23:50:54
last_update2018-05-07 23:50:54
depth1
children0
last_payout2018-05-14 23:50:54
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length125
author_reputation4,016,184,740,465
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,466,716
net_rshares0
@reazuliqbal ·
$0.04
I somehow like the idea of @finallycomments-guest commenting on behalf of the guest author by mentioning their name.

This may save you a few lines of code, some database space, and reduce latency of calling 2 data points, also can earn you some SBD and SP if anyone votes on those comments.
👍  ,
properties (23)
authorreazuliqbal
permlinkre-sambillingham-finally-comments-guest-posting-and-improvements-20180507t170350858z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-05-07 17:03:51
last_update2018-05-07 17:03:51
depth1
children6
last_payout2018-05-14 17:03:51
cashout_time1969-12-31 23:59:59
total_payout_value0.041 HBD
curator_payout_value0.002 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length291
author_reputation61,984,354,446,410
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,416,343
net_rshares10,128,569,065
author_curate_reward""
vote details (2)
@sambillingham ·
$0.03
Yeah I thought about that Idea a bunch. My main reservations are 

A) Once posted to the blockchain it can't be removed, I'd be anxious a user might post nefarious content and it would be immutably linked to a handle/user I own. 

B) You can only post every 20 seconds if Finally needs to scale it could be an issue with multiple people trying to post. Not an issue now but probably could be easily.

You're right though it saves a bunch of code and extra complexity. Still might switch to that in future, maybe there are other options i've not thought of yet too.
👍  
properties (23)
authorsambillingham
permlinkre-reazuliqbal-re-sambillingham-finally-comments-guest-posting-and-improvements-20180507t171017828z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-05-07 17:10:18
last_update2018-05-07 17:10:18
depth2
children5
last_payout2018-05-14 17:10:18
cashout_time1969-12-31 23:59:59
total_payout_value0.025 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length564
author_reputation34,876,406,478,004
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,417,294
net_rshares5,776,249,606
author_curate_reward""
vote details (1)
@reazuliqbal ·
$0.04
Yes, you are absolutely right. *B* can be bypassed using 4-5 accounts but *A* could be a real issue.

Another hack can be a placeholder comment by your handle(s) and adding `json_metadata` to that comment. This way original guest comment won't show on condensers but you can parse and show them on author's website.
👍  ,
properties (23)
authorreazuliqbal
permlinkre-sambillingham-re-reazuliqbal-re-sambillingham-finally-comments-guest-posting-and-improvements-20180507t173015130z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"busy","app":"busy/2.4.0"}
created2018-05-07 17:30:18
last_update2018-05-07 17:30:18
depth3
children4
last_payout2018-05-14 17:30:18
cashout_time1969-12-31 23:59:59
total_payout_value0.036 HBD
curator_payout_value0.008 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length315
author_reputation61,984,354,446,410
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,420,266
net_rshares9,984,020,855
author_curate_reward""
vote details (2)
@utopian-io ·
#### Hey @sambillingham
We're already looking forward to your next contribution! 

#### Contributing on Utopian
Learn how to contribute on <a href="https://join.utopian.io">our website</a> or by watching <a href="https://www.youtube.com/watch?v=8S1AtrzYY1Q">this tutorial</a> on Youtube.

##### Utopian Witness!
<a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for Utopian Witness!</a> We are made of developers, system administrators, entrepreneurs, artists, content creators, thinkers. We embrace every nationality, mindset and belief.

**Want to chat? Join us on Discord https://discord.gg/h52nFrV**
👍  
properties (23)
authorutopian-io
permlinkre-sambillingham-finally-comments-guest-posting-and-improvements-20180507t174758422z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"users":["sambillingham"],"links":["https://join.utopian.io","https://www.youtube.com/watch?v=8S1AtrzYY1Q","https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1","https://discord.gg/h52nFrV"],"app":"steemit/0.1"}
created2018-05-07 17:48:00
last_update2018-05-07 17:48:00
depth1
children1
last_payout2018-05-14 17:48:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length651
author_reputation152,955,367,999,756
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,422,914
net_rshares4,625,542,712
author_curate_reward""
vote details (1)
@sambillingham ·
⚡️⚡️Utopian Lives
👍  
properties (23)
authorsambillingham
permlinkre-utopian-io-re-sambillingham-finally-comments-guest-posting-and-improvements-20180507t181155286z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-05-07 18:11:57
last_update2018-05-07 18:11:57
depth2
children0
last_payout2018-05-14 18:11:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length17
author_reputation34,876,406,478,004
root_title"Finally Comments - Guest Posting & improvements"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id54,426,517
net_rshares2,882,370,081
author_curate_reward""
vote details (1)