create account

Fixing #2095 - Crash with enchant 2.x by tingping

View this thread on: hive.blog |  peakd.com |  ecency.com
utopian-io · @tingping · (edited)
$37.18
Fixing #2095 - Crash with enchant 2.x
Issue: [Client crashes when loading Enchant 2.x](https://github.com/hexchat/hexchat/issues/2095)

There are a few compounding problems that caused this:

- [We were loading the unversioned soname](https://github.com/hexchat/hexchat/blob/228e08543afe3fb5d15e9e3f40114f6ae1a3d793/src/fe-gtk/sexy-spell-entry.c#L164)
- [There was no error handling on failure](https://github.com/hexchat/hexchat/blob/228e08543afe3fb5d15e9e3f40114f6ae1a3d793/src/fe-gtk/sexy-spell-entry.c#L184-L186)
- [Enchant broke ABI](https://github.com/AbiWord/enchant/releases/tag/v2.0.0)

So the solution was just to avoid unversioned sonames, when something goes wrong log it and don't explode, and have fallbacks for the new ABI: https://github.com/hexchat/hexchat/commit/005858795878b92fc17b4c2127bce90a1d053483

Fixing the current problem and making it more robust in the future.

<br /><hr/><em>Posted on <a href="https://utopian.io/utopian-io/@tingping/fixing-2095-crash-with-enchant-2-x">Utopian.io -  Rewarding Open Source Contributors</a></em><hr/>
👍  , , , , , , , , ,
properties (23)
authortingping
permlinkfixing-2095-crash-with-enchant-2-x
categoryutopian-io
json_metadata"{"community":"utopian","app":"utopian/1.0.0","format":"markdown","repository":{"id":4994785,"name":"hexchat","full_name":"hexchat/hexchat","owner":{"login":"hexchat","id":1938483,"avatar_url":"https://avatars3.githubusercontent.com/u/1938483?v=4","gravatar_id":"","url":"https://api.github.com/users/hexchat","html_url":"https://github.com/hexchat","followers_url":"https://api.github.com/users/hexchat/followers","following_url":"https://api.github.com/users/hexchat/following{/other_user}","gists_url":"https://api.github.com/users/hexchat/gists{/gist_id}","starred_url":"https://api.github.com/users/hexchat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexchat/subscriptions","organizations_url":"https://api.github.com/users/hexchat/orgs","repos_url":"https://api.github.com/users/hexchat/repos","events_url":"https://api.github.com/users/hexchat/events{/privacy}","received_events_url":"https://api.github.com/users/hexchat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hexchat/hexchat","description":"GTK+ IRC client -","fork":false,"url":"https://api.github.com/repos/hexchat/hexchat","forks_url":"https://api.github.com/repos/hexchat/hexchat/forks","keys_url":"https://api.github.com/repos/hexchat/hexchat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexchat/hexchat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexchat/hexchat/teams","hooks_url":"https://api.github.com/repos/hexchat/hexchat/hooks","issue_events_url":"https://api.github.com/repos/hexchat/hexchat/issues/events{/number}","events_url":"https://api.github.com/repos/hexchat/hexchat/events","assignees_url":"https://api.github.com/repos/hexchat/hexchat/assignees{/user}","branches_url":"https://api.github.com/repos/hexchat/hexchat/branches{/branch}","tags_url":"https://api.github.com/repos/hexchat/hexchat/tags","blobs_url":"https://api.github.com/repos/hexchat/hexchat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexchat/hexchat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexchat/hexchat/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexchat/hexchat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexchat/hexchat/statuses/{sha}","languages_url":"https://api.github.com/repos/hexchat/hexchat/languages","stargazers_url":"https://api.github.com/repos/hexchat/hexchat/stargazers","contributors_url":"https://api.github.com/repos/hexchat/hexchat/contributors","subscribers_url":"https://api.github.com/repos/hexchat/hexchat/subscribers","subscription_url":"https://api.github.com/repos/hexchat/hexchat/subscription","commits_url":"https://api.github.com/repos/hexchat/hexchat/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexchat/hexchat/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexchat/hexchat/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexchat/hexchat/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexchat/hexchat/contents/{+path}","compare_url":"https://api.github.com/repos/hexchat/hexchat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexchat/hexchat/merges","archive_url":"https://api.github.com/repos/hexchat/hexchat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexchat/hexchat/downloads","issues_url":"https://api.github.com/repos/hexchat/hexchat/issues{/number}","pulls_url":"https://api.github.com/repos/hexchat/hexchat/pulls{/number}","milestones_url":"https://api.github.com/repos/hexchat/hexchat/milestones{/number}","notifications_url":"https://api.github.com/repos/hexchat/hexchat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexchat/hexchat/labels{/name}","releases_url":"https://api.github.com/repos/hexchat/hexchat/releases{/id}","deployments_url":"https://api.github.com/repos/hexchat/hexchat/deployments","created_at":"2012-07-11T20:42:10Z","updated_at":"2017-11-25T03:50:18Z","pushed_at":"2017-11-24T08:57:35Z","git_url":"git://github.com/hexchat/hexchat.git","ssh_url":"git@github.com:hexchat/hexchat.git","clone_url":"https://github.com/hexchat/hexchat.git","svn_url":"https://github.com/hexchat/hexchat","homepage":"https://hexchat.github.io","size":21845,"stargazers_count":1643,"watchers_count":1643,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":340,"mirror_url":null,"archived":false,"open_issues_count":538,"forks":340,"open_issues":538,"watchers":1643,"default_branch":"master","score":153.06262},"pullRequests":[],"platform":"github","type":"development","tags":["utopian-io","linux"],"users":["tingping"],"links":["https://github.com/hexchat/hexchat/issues/2095","https://github.com/hexchat/hexchat/blob/228e08543afe3fb5d15e9e3f40114f6ae1a3d793/src/fe-gtk/sexy-spell-entry.c#L164","https://github.com/hexchat/hexchat/blob/228e08543afe3fb5d15e9e3f40114f6ae1a3d793/src/fe-gtk/sexy-spell-entry.c#L184-L186","https://github.com/AbiWord/enchant/releases/tag/v2.0.0"]}"
created2017-11-25 04:58:21
last_update2017-11-25 10:38:48
depth0
children8
last_payout2017-12-02 04:58:21
cashout_time1969-12-31 23:59:59
total_payout_value26.266 HBD
curator_payout_value10.914 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,026
author_reputation637,453,434,557
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries
0.
accountespoem
weight97
1.
accountfreedom
weight659
2.
accountmisterdelegation
weight549
3.
accountned
weight544
4.
accountruah
weight60
5.
accounttransisto
weight71
6.
accountwackou
weight53
7.
accountxeldal
weight27
max_accepted_payout1,000,000.000 HBD
percent_hbd5,000
post_id21,451,996
net_rshares18,833,857,395,475
author_curate_reward""
vote details (10)
@bitgeek ·
comment
Congratulations @tingping, this post is the tenth most rewarded post (based on pending payouts) in the last 12 hours written by a Dust account holder (accounts that hold between 0 and 0.01 Mega Vests). The total number of posts by Dust account holders during this period was 2917 and the total pending payments to posts in this category was $458.56. To see the full list of highest paid posts across all accounts categories, [click here](www.steemit.com/steemit/@bitgeek/payout-stats-report-for-25th-november-2017--part-ii). 

If you do not wish to receive these messages in future, please reply stop to this comment.
properties (22)
authorbitgeek
permlinkre-fixing-2095-crash-with-enchant-2-x-20171125t072428
categoryutopian-io
json_metadata""
created2017-11-25 07:24:30
last_update2017-11-25 07:24:30
depth1
children0
last_payout2017-12-02 07:24:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length618
author_reputation13,049,044,453,787
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,460,048
net_rshares0
@mcfarhat · 
Your contribution cannot be approved yet, because it is in the **wrong category.** 
This looks like development work, so the correct category for your post would be 'development'. 
Also please include links within your post of the relevant pull request(s).
See the [Utopian Rules](https://utopian.io/rules). Please edit your post to use the right category at [this link](https://utopian.io/utopian-io/@tingping/fixing-2095-crash-with-enchant-2-x), as shown below: 
![](https://res.cloudinary.com/hpiynhbhq/image/upload/v1509788371/nbgbomithszxs3nxq6gx.png)

You can contact us on [Discord](https://discord.gg/UCvqCsx).
**[[utopian-moderator]](https://utopian.io/moderators)**
properties (22)
authormcfarhat
permlinkre-tingping-fixing-2095-crash-with-enchant-2-x-20171125t103622497z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2017-11-25 10:36:30
last_update2017-11-25 10:36:30
depth1
children4
last_payout2017-12-02 10:36:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length675
author_reputation150,651,671,367,256
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,471,790
net_rshares0
@tingping · 
Fixed.
properties (22)
authortingping
permlinkre-mcfarhat-re-tingping-fixing-2095-crash-with-enchant-2-x-20171125t104012447z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2017-11-25 10:40:12
last_update2017-11-25 10:40:12
depth2
children3
last_payout2017-12-02 10:40:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length6
author_reputation637,453,434,557
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,472,026
net_rshares0
@mcfarhat · 
I saw you fixed the category.
You did not include a link to the pull request, are there no relevant pull requests?
also in order for dev work to be approved, it needs to have been merged by the project owner. Checking your commit, it appears it has not yet been merged. If that is the case at the time being we cannot accept it, but would be open to do so once it has been approved and merged.
properties (22)
authormcfarhat
permlinkre-tingping-re-mcfarhat-re-tingping-fixing-2095-crash-with-enchant-2-x-20171125t205158453z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2017-11-25 20:52:06
last_update2017-11-25 20:52:06
depth3
children2
last_payout2017-12-02 20:52:06
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length394
author_reputation150,651,671,367,256
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,515,288
net_rshares0
@steemitboard · 
Congratulations @tingping! You have completed some achievement on Steemit and have been rewarded with new badge(s) :

[![](https://steemitimages.com/70x80/http://steemitboard.com/notifications/firstcomment.png)](http://steemitboard.com/@tingping) You made your First Comment

Click on any badge to view your own Board of Honor on SteemitBoard.
For more information about SteemitBoard, click [here](https://steemit.com/@steemitboard)

If you no longer want to receive notifications, reply to this comment with the word `STOP`

> By upvoting this notification, you can help all Steemit users. Learn how [here](https://steemit.com/steemitboard/@steemitboard/http-i-cubeupload-com-7ciqeo-png)!
properties (22)
authorsteemitboard
permlinksteemitboard-notify-tingping-20171125t125857000z
categoryutopian-io
json_metadata{"image":["https://steemitboard.com/img/notifications.png"]}
created2017-11-25 12:58:57
last_update2017-11-25 12:58:57
depth1
children0
last_payout2017-12-02 12:58:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length689
author_reputation38,975,615,169,260
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,481,074
net_rshares0
@utopian-io · 
### Hey @tingping I am @utopian-io. I have just upvoted you at 11% Power!
#### Achievements
- You have less than 500 followers. Just gave you a gift to help you succeed!
- This is your first accepted contribution here in Utopian. Welcome!
#### Community-Driven Witness!
I am the first and only Steem Community-Driven Witness. <a href="https://discord.gg/zTrEMqB">Participate on Discord</a>. Lets GROW TOGETHER!
- <a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for my Witness With SteemConnect</a>
- <a href="https://v2.steemconnect.com/sign/account-witness-proxy?proxy=utopian-io&approve=1">Proxy vote to Utopian Witness with SteemConnect</a>
- Or vote/proxy on <a href="https://steemit.com/~witnesses">Steemit Witnesses</a>

[![mooncryption-utopian-witness-gif](https://steemitimages.com/DQmYPUuQRptAqNBCQRwQjKWAqWU3zJkL3RXVUtEKVury8up/mooncryption-s-utopian-io-witness-gif.gif)](https://steemit.com/~witnesses)

**Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x**
properties (22)
authorutopian-io
permlinkre-tingping-fixing-2095-crash-with-enchant-2-x-20171127t234536291z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"utopian","app":"utopian/1.0.0"}
created2017-11-27 23:45:36
last_update2017-11-27 23:45:36
depth1
children0
last_payout2017-12-04 23:45:36
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,116
author_reputation152,955,367,999,756
root_title"Fixing #2095 - Crash with enchant 2.x"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id21,723,176
net_rshares0
Help/Feedback