RE: Code Wars Python Challenge: Vowel Count by steevc

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @themarkymark/code-wars-python-challenge-vowel-count

codewithmarky · @steevc · Sep 14 '20

List comprehensions are cool, but putting everything in one line can make code hard to debug. Starting with a more step by step approach can help validate your algorithm. I notice one of the solutions checks for upper case, but the exercise specified it was all lower case. 

I've been doing a course that uses functional languages where you are discouraged from using loops. That means lots of recursion which can be inefficient in some language, but can make for elegant code.

properties (22)

`author`	steevc
`permlink`	re-themarkymark-qgn3jr
`category`	codewithmarky
`json_metadata`	{"tags":["codewithmarky"],"app":"peakd/2020.09.4"}
`created`	2020-09-14 08:28:39
`last_update`	2020-09-14 08:28:39
`depth`	1
`children`	3
`last_payout`	2020-09-21 08:28:39
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	478
`author_reputation`	1,383,331,593,704,510
`root_title`	"Code Wars Python Challenge: Vowel Count"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	99,618,849
`net_rshares`	0

@themarkymark · Sep 14 '20 (edited)

List comprehensions are the preferred way to iterate in Python.  It is considered the "Pythonic" way to do things. 

For the upper() you mean the RGB to hex challenge?  I noticed the test output required upper case. The solution also showed uppercase output.

👍 sultan-indo
👎 block-power

`author`	themarkymark
`permlink`	re-steevc-qgn456
`category`	codewithmarky
`json_metadata`	{"tags":["codewithmarky"],"app":"peakd/2020.09.4"}
`created`	2020-09-14 08:41:30
`last_update`	2020-09-14 08:43:12
`depth`	2
`children`	2
`last_payout`	2020-09-21 08:41:30
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	260
`author_reputation`	1,777,423,768,627,181
`root_title`	"Code Wars Python Challenge: Vowel Count"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	99,618,961
`net_rshares`	-155,229,000,897
`author_curate_reward`	""

properties (23)vote details (2)

voter	weight	wgt%	rshares	pct	time
block-power	0 B		-160,478,070,768	-100%
sultan-indo	0 B		5,249,069,871	100%

@steevc · Sep 14 '20

From experience I know that writing the shortest code can cause issues when you need to expand functionality later. Need to consider what is best for each case. Sometimes shorter code is not necessarily more efficient. It depends a lot on optimisations done in the compiler or interpreter and they are pretty clever these days.

The one line solution for finding vowels had 

in 'aeiouAEIOU'

but that went beyond the requirement.

properties (22)

`author`	steevc
`permlink`	re-themarkymark-qgn56b
`category`	codewithmarky
`json_metadata`	{"tags":["codewithmarky"],"app":"peakd/2020.09.4"}
`created`	2020-09-14 09:03:48
`last_update`	2020-09-14 09:03:48
`depth`	3
`children`	1
`last_payout`	2020-09-21 09:03:48
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	430
`author_reputation`	1,383,331,593,704,510
`root_title`	"Code Wars Python Challenge: Vowel Count"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	99,619,171
`net_rshares`	0

@themarkymark · Sep 14 '20

Oh I thought you meant one of my solutions so I looked through my older posts lol. 

I agree about shorter code isn't better all the time I've mentioned it in most of my posts.

👍 sultan-indo
👎 bullionstackers

`author`	themarkymark
`permlink`	re-steevc-qgn5ch
`category`	codewithmarky
`json_metadata`	{"tags":["codewithmarky"],"app":"peakd/2020.09.4"}
`created`	2020-09-14 09:07:30
`last_update`	2020-09-14 09:07:30
`depth`	4
`children`	0
`last_payout`	2020-09-21 09:07:30
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	177
`author_reputation`	1,777,423,768,627,181
`root_title`	"Code Wars Python Challenge: Vowel Count"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	99,619,202
`net_rshares`	-726,092,088,504
`author_curate_reward`	""

properties (23)vote details (2)

voter	weight	wgt%	rshares	pct	time
bullionstackers	0 B		-731,449,038,096	-100%
sultan-indo	0 B		5,356,949,592	100%