create account

RE: I submitted my first hardfork pull request to the Steem blockchain! (Updates to the SBD print rate.) by sorin.cristescu

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @timcliff/i-submitted-my-first-hardfork-pull-request-to-the-steem-blockchain-updates-to-the-sbd-print-rate

· @sorin.cristescu ·
$0.10
Very good approach, I am fully with you on the need for the community to step up and live the "decentralized" idea in full - not only decentralized operations but also a community of developers that is decentralized and generates new ideas faster than in a centralized setting.

With the "selection mechanism" of the witness approval vote - which BTW happens where, in github or in steem.chat or is it simply by upgrading the code they run ? I'm curious how things work during the transition period - when some witnesses have upgraded but others not - what happens to a specific payout then depends on what version runs on the node that processes the "author reward transaction", right ?
👍  ,
properties (23)
authorsorin.cristescu
permlinkre-timcliff-i-submitted-my-first-hardfork-pull-request-to-the-steem-blockchain-updates-to-the-sbd-print-rate-20180610t131443397z
categorysteem
json_metadata{"tags":["steem"],"app":"steemit/0.1"}
created2018-06-10 13:14:42
last_update2018-06-10 13:14:42
depth1
children5
last_payout2018-06-17 13:14:42
cashout_time1969-12-31 23:59:59
total_payout_value0.096 HBD
curator_payout_value0.003 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length687
author_reputation256,493,299,593,538
root_title"I submitted my first hardfork pull request to the Steem blockchain! (Updates to the SBD print rate.)"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,139,311
net_rshares37,830,483,805
author_curate_reward""
vote details (2)
@timcliff ·
Witnesses 'vote yes' for a hardfork by applying it to their servers. It will only take effect if 17/21 witnesses (including the 20 primary and one backup) vote yes.
properties (22)
authortimcliff
permlinkre-sorincristescu-re-timcliff-i-submitted-my-first-hardfork-pull-request-to-the-steem-blockchain-updates-to-the-sbd-print-rate-20180610t164851873z
categorysteem
json_metadata{"tags":["steem"],"app":"steemit/0.1"}
created2018-06-10 16:48:12
last_update2018-06-10 16:48:12
depth2
children4
last_payout2018-06-17 16:48:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length164
author_reputation272,954,445,077,789
root_title"I submitted my first hardfork pull request to the Steem blockchain! (Updates to the SBD print rate.)"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,165,968
net_rshares0
@sorin.cristescu ·
$0.03
Thanks. Now imagine a 0.19.5 which inclides your change is available. Some of the witnesses start applying it. We are in a round where some witnesses (say 5 of the first 20) run 0.19.5 (with the modification) and the remaining ones (15 plus the backup) run 0.19.4 without the modification. Some "author reward" transactions come up for processing for the next block and one of the witnesses who has applied 0.19.5 is up for signing that one. What happens there ? In theory the author reward should be processed with the rules of 0.19.4 because your modification hasn't been approved yet by 17 witnesses. But because this witness has applied 0.19.5 his results will be different, his block will be considered "out of consensus" and thrown out, is that correct ? Which indicates that witnesses are well advised to do the coordination "out of band" in a chat so that the disruption is minimized, correct ?
👍  
properties (23)
authorsorin.cristescu
permlinkre-timcliff-re-sorincristescu-re-timcliff-i-submitted-my-first-hardfork-pull-request-to-the-steem-blockchain-updates-to-the-sbd-print-rate-20180611t065307607z
categorysteem
json_metadata{"tags":["steem"],"app":"steemit/0.1"}
created2018-06-11 06:53:12
last_update2018-06-11 06:53:12
depth3
children3
last_payout2018-06-18 06:53:12
cashout_time1969-12-31 23:59:59
total_payout_value0.024 HBD
curator_payout_value0.001 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length902
author_reputation256,493,299,593,538
root_title"I submitted my first hardfork pull request to the Steem blockchain! (Updates to the SBD print rate.)"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,252,157
net_rshares10,557,485,048
author_curate_reward""
vote details (1)
@timcliff ·
$0.05
That's not really how it works..

It is just a technicality, but the version numbers are based on whatever hardfork version it is in. A change to 19.5 can not be one that causes a fork from a previous version of 19. If it is a hardfork, then it will be version 0.20.0. 

Whenever there is a hardfork, there is a specific point in time where all the nodes will switch if there is at least 17 'yes' votes.

If I apply hardfork 20, then I am voting 'yes' for that change. Even though I am voting yes, I am still processing blocks in 'hardfork 19' mode unless/until 17/21 witnesses accept, and the hardfork occurs at whatever time it is scheduled to happen in the code.
👍  
properties (23)
authortimcliff
permlinkre-sorincristescu-re-timcliff-re-sorincristescu-re-timcliff-i-submitted-my-first-hardfork-pull-request-to-the-steem-blockchain-updates-to-the-sbd-print-rate-20180611t070313705z
categorysteem
json_metadata{"tags":["steem"],"app":"steemit/0.1"}
created2018-06-11 07:02:33
last_update2018-06-11 07:02:33
depth4
children2
last_payout2018-06-18 07:02:33
cashout_time1969-12-31 23:59:59
total_payout_value0.034 HBD
curator_payout_value0.011 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length665
author_reputation272,954,445,077,789
root_title"I submitted my first hardfork pull request to the Steem blockchain! (Updates to the SBD print rate.)"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id60,253,162
net_rshares17,677,579,980
author_curate_reward""
vote details (1)