RE: CLOSED: 125 STEEM Developer Bounty Inside [Python] by emrebeyler

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @felixxx/125-steem-developer-bounty-inside-python

steemdev · @emrebeyler · Feb 1 '18

$2.32

hi @felixxx,

The script looks like too messy to refactor. I can do a complete rewrite in 24 hours for a total 125 STEEM. What do you think about that? I am experienced w/ discord and steem api's.

👍 felixxx, ace108, crokkon, turbot, fuchsfalke

`author`	emrebeyler
`permlink`	re-felixxx-125-steem-developer-bounty-inside-python-20180201t083925925z
`category`	steemdev
`json_metadata`	{"tags":["steemdev"],"users":["felixxx"],"app":"steemit/0.1"}
`created`	2018-02-01 08:39:27
`last_update`	2018-02-01 08:39:27
`depth`	1
`children`	7
`last_payout`	2018-02-08 08:39:27
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	1.748 HBD
`curator_payout_value`	0.567 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	196
`author_reputation`	448,535,049,068,622
`root_title`	"CLOSED: 125 STEEM Developer Bounty Inside [Python]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	34,078,341
`net_rshares`	373,471,403,409
`author_curate_reward`	""

properties (23)vote details (5)

voter	rshares	pct
ace108	13,957,081,413	1%
felixxx	342,628,974,949	100%
crokkon	10,825,338,527	50%
turbot	5,562,835,903	100%
fuchsfalke	497,172,617	100%

@ace108 · Feb 1 '18

$2.09

Don't know enough Python but totally agree sometimes to clean up the mess takes a longer time than to redesign and rewrite the thing :-)

👍 felixxx

`author`	ace108
`permlink`	re-emrebeyler-re-felixxx-125-steem-developer-bounty-inside-python-20180201t091729382z
`category`	steemdev
`json_metadata`	{"tags":["steemdev"],"app":"steemit/0.1"}
`created`	2018-02-01 09:17:30
`last_update`	2018-02-01 09:17:30
`depth`	2
`children`	0
`last_payout`	2018-02-08 09:17:30
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	1.570 HBD
`curator_payout_value`	0.521 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	136
`author_reputation`	1,233,738,170,400,275
`root_title`	"CLOSED: 125 STEEM Developer Bounty Inside [Python]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	34,085,443
`net_rshares`	336,918,492,033
`author_curate_reward`	""

properties (23)vote details (1)

voter	weight	wgt%	rshares	pct	time
felixxx	0 B		336,918,492,033	100%

@felixxx · Feb 1 '18

I agree, that it really is messy.

If you did a complete redesign, I'd like to plan ahead for some extra features.

I'll just wait for some more replies, to give others a chance - Hope that's ok.

properties (22)

`author`	felixxx
`permlink`	re-emrebeyler-re-felixxx-125-steem-developer-bounty-inside-python-20180201t084506985z
`category`	steemdev
`json_metadata`	{"tags":["steemdev"],"app":"steemit/0.1"}
`created`	2018-02-01 08:45:09
`last_update`	2018-02-01 08:45:09
`depth`	2
`children`	5
`last_payout`	2018-02-08 08:45:09
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	195
`author_reputation`	218,698,764,507,703
`root_title`	"CLOSED: 125 STEEM Developer Bounty Inside [Python]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	34,079,469
`net_rshares`	0

@emrebeyler · Feb 1 '18

$2.31

No problem.

I have a couple of ideas:

- Don't parse every block. Instead use get_account_history for each curator and filter only votes. Much more cleaner code and less overhead. This will remove almost half of the code. 

- Use mongodb to log already sent votes and [check](https://github.com/utopian-io/utopian.tip/blob/master/utopian_tip/utopian_tip.py#L86) from there.

- Use supervisord to restart the bot if bot goes down. Fixing the main reason is the real solution however you can always use Supervisord to auto-restart the process.

- Custom node settings are not valid on some internal classes of steem-python. There are a couple of pull requests waiting for approval about this issue but they didn't do that yet. Using get_account_history with a custom list of nodes working well though. So, this won't be a o problem.

Let me know, if you decide for a rewrite.

my Discord id: emre#9263.

👍 felixxx, turbot, fuchsfalke

`author`	emrebeyler
`permlink`	re-felixxx-re-emrebeyler-re-felixxx-125-steem-developer-bounty-inside-python-20180201t085732263z
`category`	steemdev
`json_metadata`	{"tags":["steemdev"],"links":["https://github.com/utopian-io/utopian.tip/blob/master/utopian_tip/utopian_tip.py#L86"],"app":"steemit/0.1"}
`created`	2018-02-01 08:57:33
`last_update`	2018-02-01 08:57:33
`depth`	3
`children`	4
`last_payout`	2018-02-08 08:57:33
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	2.244 HBD
`curator_payout_value`	0.070 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	901
`author_reputation`	448,535,049,068,622
`root_title`	"CLOSED: 125 STEEM Developer Bounty Inside [Python]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	34,081,773
`net_rshares`	373,295,077,721
`author_curate_reward`	""

properties (23)vote details (3)

voter	rshares	pct
felixxx	367,374,400,917	100%
turbot	5,432,711,087	100%
fuchsfalke	487,965,717	100%

@felixxx · Feb 1 '18

Another feature of the bot ( which now runs as a separate script ) is to drop a comment under posts, when the author has used #deutsch for the first time.

To integrate that I'd need to get all blocks.

properties (22)

`author`	felixxx
`permlink`	re-emrebeyler-re-felixxx-re-emrebeyler-re-felixxx-125-steem-developer-bounty-inside-python-20180201t090508209z
`category`	steemdev
`json_metadata`	{"tags":["steemdev","deutsch"],"app":"steemit/0.1"}
`created`	2018-02-01 09:05:09
`last_update`	2018-02-01 09:05:09
`depth`	4
`children`	3
`last_payout`	2018-02-08 09:05:09
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	201
`author_reputation`	218,698,764,507,703
`root_title`	"CLOSED: 125 STEEM Developer Bounty Inside [Python]"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	34,083,134
`net_rshares`	0

3 replies