RE: steemgg open source development update - 2018.8.18 by codingdefined

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @steemgg/steemgg-open-source-development-update-2018-8-18

steemgg · @codingdefined · Aug 19 '18

$10.58

Thank you for your contribution, its good to see the website is improving. Bdw just to be clear that according to our guidelines we only take into consideration new features and not bug fixes i.e. "Bug Fixes for contributor’s Own Projects will not be considered for potential reward, unless the Bugs were caused by third party dependencies."

Also for this line as well as some other places  https://github.com/steemgg/steemgg-website/commit/2827939ff7ed0124a0388fa586caedb703e3a15d#diff-066ae30720ba6a3d92415204b85bade1R55 wouldn't it be better to read the url from a config file instead of hardcoding.


Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2322223).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, steemgg, amosbastian, azizbd, steemtaker

`author`	codingdefined
`permlink`	re-steemgg-steemgg-open-source-development-update-2018-8-18-20180819t110420964z
`category`	steemgg
`json_metadata`	{"tags":["steemgg"],"links":["https://github.com/steemgg/steemgg-website/commit/2827939ff7ed0124a0388fa586caedb703e3a15d#diff-066ae30720ba6a3d92415204b85bade1R55","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2322223","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
`created`	2018-08-19 11:04:21
`last_update`	2018-08-19 11:04:21
`depth`	1
`children`	2
`last_payout`	2018-08-26 11:04:21
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	7.969 HBD
`curator_payout_value`	2.612 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	1,095
`author_reputation`	534,415,385,523,394
`root_title`	"steemgg open source development update - 2018.8.18"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	68,687,124
`net_rshares`	7,907,151,143,662
`author_curate_reward`	""

properties (23)vote details (5)

voter	rshares	pct
azizbd	2,303,392,031	2%
utopian-io	7,574,206,266,609	10.58%
steemtaker	458,671,266	1%
amosbastian	6,232,157,610	8.79%
steemgg	323,950,656,146	100%

@steemgg · Aug 19 '18

@codingdefined,

Thanks a lot for your review and feedback. 

We'll continue improving our website and the code quality, especially what you've mentioned: "wouldn't it be better to read the url from a config file instead of hardcoding."

And also thanks for your clarification of bug fixing is not suitable putting here for project owner, so we will exclude them next time. :)

Cheers.

properties (22)

`author`	steemgg
`permlink`	re-codingdefined-re-steemgg-steemgg-open-source-development-update-2018-8-18-20180819t113543893z
`category`	steemgg
`json_metadata`	{"tags":["steemgg"],"users":["codingdefined"],"app":"steemit/0.1"}
`created`	2018-08-19 11:35:45
`last_update`	2018-08-19 11:35:45
`depth`	2
`children`	0
`last_payout`	2018-08-26 11:35:45
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	385
`author_reputation`	14,473,317,256,440
`root_title`	"steemgg open source development update - 2018.8.18"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	68,689,363
`net_rshares`	0

@utopian-io · Aug 21 '18

Thank you for your review, @codingdefined!

So far this week you've reviewed 7 contributions. Keep up the good work!

properties (22)