RE: Steem Smart Contracts: interaction via cutom json and transfer operations by codingdefined

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @harpagon/steem-smart-contracts-interaction-via-cutom-json-and-transfer-operations

utopian-io · @codingdefined · Aug 21 '18 (edited)

$5.67

Thank you for your contribution. You are disallowing the console on this line 
 https://github.com/harpagon210/steemsmartcontracts/commit/35393c51be239d45eadb37ab259a1a6902f04214#diff-8e89c85f3650e78ec257a307fc4212f9R115, but I could not find any configuration of the same? Am I missing something?

Also in some places you are hardcoding some of the values like ssc, transfer,start block etc, can this be moved in a config file and then read it from there, because for example in the future if it changes you have to change everywhere wherever you are using it.


Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2332222).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, harpagon, espoem, amosbastian, pixelfan, steemtaker, mys, mops2e

`author`	codingdefined
`permlink`	re-harpagon-steem-smart-contracts-interaction-via-cutom-json-and-transfer-operations-20180821t043851780z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"links":["https://github.com/harpagon210/steemsmartcontracts/commit/35393c51be239d45eadb37ab259a1a6902f04214#diff-8e89c85f3650e78ec257a307fc4212f9R115","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2332222","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
`created`	2018-08-21 04:38:51
`last_update`	2018-08-21 04:41:15
`depth`	1
`children`	2
`last_payout`	2018-08-28 04:38:51
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	4.276 HBD
`curator_payout_value`	1.389 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	1,053
`author_reputation`	528,734,044,258,837
`root_title`	"Steem Smart Contracts: interaction via cutom json and transfer operations"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	68,873,865
`net_rshares`	4,178,578,109,450
`author_curate_reward`	""

properties (23)vote details (8)

voter	rshares	pct
mys	1,788,127,666	1.81%
pixelfan	3,547,056,079	2%
espoem	14,889,068,288	15%
utopian-io	4,128,528,245,393	5.57%
steemtaker	2,064,408,826	6%
amosbastian	12,118,084,243	19.21%
harpagon	15,303,390,779	100%
mops2e	339,728,176	10%

@harpagon · Aug 21 '18

$0.04

Thanks for the review @codingdefined !

I disallowed the console because I figured out that it was logging too much unnecessary data... I should try to work on something that could allow/disallow the console debugging (an entry in the config file?)

I'll try to work on the hardcoded data to make everything a bit more flexible.

Thanks for the inputs, appreciate!

👍 dj123

`author`	harpagon
`permlink`	re-codingdefined-re-harpagon-steem-smart-contracts-interaction-via-cutom-json-and-transfer-operations-20180821t131656534z
`category`	utopian-io
`json_metadata`	{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["codingdefined"],"links":["/@codingdefined"],"image":[]}
`created`	2018-08-21 13:16:57
`last_update`	2018-08-21 13:16:57
`depth`	2
`children`	0
`last_payout`	2018-08-28 13:16:57
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.030 HBD
`curator_payout_value`	0.009 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	364
`author_reputation`	20,287,642,226,146
`root_title`	"Steem Smart Contracts: interaction via cutom json and transfer operations"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	68,912,732
`net_rshares`	30,128,836,814
`author_curate_reward`	""

properties (23)vote details (1)

voter	weight	wgt%	rshares	pct	time
dj123	0 B		30,128,836,814	100%

@utopian-io · Aug 24 '18

$0.02

Thank you for your review, @codingdefined!

So far this week you've reviewed 12 contributions. Keep up the good work!

👍 espoem, mops2e

`author`	utopian-io
`permlink`	re-re-harpagon-steem-smart-contracts-interaction-via-cutom-json-and-transfer-operations-20180821t043851780z-20180824t051009z
`category`	utopian-io
`json_metadata`	"{"app": "beem/0.19.42"}"
`created`	2018-08-24 05:10:09
`last_update`	2018-08-24 05:10:09
`depth`	2
`children`	0
`last_payout`	2018-08-31 05:10:09
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.018 HBD
`curator_payout_value`	0.004 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	117
`author_reputation`	152,955,367,999,756
`root_title`	"Steem Smart Contracts: interaction via cutom json and transfer operations"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	69,192,836
`net_rshares`	16,328,992,909
`author_curate_reward`	""

properties (23)vote details (2)

voter	weight	wgt%	rshares	pct	time
espoem	0 B		16,006,251,142	15%
mops2e	0 B		322,741,767	10%