Viewing a response to: @petertag/pywit-version-1-1-1-and-utopian-io-submission
Hi there, Pywit looks good. Since you didn't share the original announcement post on Utopian, I will review the project as a whole instead of the recent updates. - It seems pywit lacks support for ```witness_set_properties``` operation. It would be good if we have support for that. It's possible to broadcast witness updates (on witness params) by witnes' signing key. Which is useful on many cases. - There are a couple of undefined ```self``` calls.<sup>[1](https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L67), [2](https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L88)</sup> causes errors on some calls. (See [an example log](https://gist.github.com/emre/374edd47f340c32c7a54d38f016c7c71)) - Regarding testing user inputs, you can have a look to one of my projects' testing file: https://github.com/emre/storm/blob/master/tests.py#L82. ```run_cmd``` and ```test_list_command``` functions may give a clue. *** Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/3222222). ---- Need help? Write a ticket on https://support.utopian.io/. Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
author | emrebeyler |
---|---|
permlink | re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t072044678z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L67","https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L88","https://gist.github.com/emre/374edd47f340c32c7a54d38f016c7c71","https://github.com/emre/storm/blob/master/tests.py#L82","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/3222222","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"} |
created | 2018-10-31 07:20:45 |
last_update | 2018-10-31 07:20:45 |
depth | 1 |
children | 4 |
last_payout | 2018-11-07 07:20:45 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 7.232 HBD |
curator_payout_value | 2.311 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 1,437 |
author_reputation | 448,535,049,068,622 |
root_title | "Pywit Version 1.1.1 & Utopian-io Submission" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 74,391,086 |
net_rshares | 8,372,954,789,628 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
espoem | 0 | 8,087,248,347 | 5% | ||
utopian-io | 0 | 8,267,159,571,707 | 5.83% | ||
emrebeyler | 0 | 14,913,740,363 | 1% | ||
aydant | 0 | 4,769,194,640 | 50% | ||
amosbastian | 0 | 17,023,179,206 | 8.82% | ||
organicgardener | 0 | 4,848,578,352 | 25% | ||
reazuliqbal | 0 | 4,970,421,986 | 8% | ||
hakancelik | 0 | 13,516,028,541 | 20% | ||
statsexpert | 0 | 6,328,205,015 | 100% | ||
mightypanda | 0 | 29,442,345,576 | 30% | ||
fastandcurious | 0 | 1,896,275,895 | 55% |
Great, thanks for the errors you pointed out! I saw your comment on bobinson's post about pipfiles, I was wondering the reason you're not a big fan, since I don't have an opinion one way or the other yet. I had setup.py because it was easy to setup and figure out, basically for a quickstart, wasn't sure what the differences were when I was choosing one to use.
author | petertag |
---|---|
permlink | re-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t200811101z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"app":"steemit/0.1"} |
created | 2018-10-31 20:07:42 |
last_update | 2018-10-31 20:07:42 |
depth | 2 |
children | 0 |
last_payout | 2018-11-07 20:07:42 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 362 |
author_reputation | 17,170,168,350,944 |
root_title | "Pywit Version 1.1.1 & Utopian-io Submission" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 74,430,681 |
net_rshares | 0 |
Hey again, do you have any docs on the witness_set_properties using the witness's public signing key? So far I don't think beempy supports it, but I could look into setting up a workaround in pywit. Or is it just with the private signing key that you mean?
author | petertag |
---|---|
permlink | re-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t205624956z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"app":"steemit/0.1"} |
created | 2018-10-31 20:55:57 |
last_update | 2018-10-31 20:55:57 |
depth | 2 |
children | 1 |
last_payout | 2018-11-07 20:55:57 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 257 |
author_reputation | 17,170,168,350,944 |
root_title | "Pywit Version 1.1.1 & Utopian-io Submission" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 74,433,309 |
net_rshares | 0 |
You can sign with the private signing key. (witness key) Check [here](https://github.com/emre/transmitter/blob/master/transmitter/main.py#L134) for an example for witness_set_properties.
author | emrebeyler |
---|---|
permlink | re-petertag-re-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181101t083703497z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https://github.com/emre/transmitter/blob/master/transmitter/main.py#L134"],"app":"steemit/0.1"} |
created | 2018-11-01 08:37:03 |
last_update | 2018-11-01 08:37:03 |
depth | 3 |
children | 0 |
last_payout | 2018-11-08 08:37:03 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 188 |
author_reputation | 448,535,049,068,622 |
root_title | "Pywit Version 1.1.1 & Utopian-io Submission" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 74,462,365 |
net_rshares | 0 |
Thank you for your review, @emrebeyler! Keep up the good work!
author | utopian-io |
---|---|
permlink | re-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t072044678z-20181103t010922z |
category | utopian-io |
json_metadata | "{"app": "beem/0.20.9"}" |
created | 2018-11-03 01:09:24 |
last_update | 2018-11-03 01:09:24 |
depth | 2 |
children | 0 |
last_payout | 2018-11-10 01:09:24 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 62 |
author_reputation | 152,955,367,999,756 |
root_title | "Pywit Version 1.1.1 & Utopian-io Submission" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 74,574,130 |
net_rshares | 0 |