create account

RE: Pywit Version 1.1.1 & Utopian-io Submission by emrebeyler

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @petertag/pywit-version-1-1-1-and-utopian-io-submission

· @emrebeyler ·
$9.54
Hi there,

Pywit looks good.


Since you didn't share the original announcement post on Utopian, I will review the project as a whole instead of the recent updates.

- It seems pywit lacks support for ```witness_set_properties``` operation. It would be good if we have support for that. It's possible to broadcast witness updates (on witness params) by witnes' signing key. Which is useful on many cases.

- There are a couple of undefined ```self``` calls.<sup>[1](https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L67), [2](https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L88)</sup> causes errors on some calls. (See [an example log](https://gist.github.com/emre/374edd47f340c32c7a54d38f016c7c71))

- Regarding testing user inputs, you can have a look to one of my projects' testing file: https://github.com/emre/storm/blob/master/tests.py#L82. ```run_cmd``` and ```test_list_command``` functions may give a clue.

***

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/3222222).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , ,
properties (23)
authoremrebeyler
permlinkre-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t072044678z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L67","https://github.com/gitschwifty/pywit/blob/master/pywit/cli.py#L88","https://gist.github.com/emre/374edd47f340c32c7a54d38f016c7c71","https://github.com/emre/storm/blob/master/tests.py#L82","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/3222222","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2018-10-31 07:20:45
last_update2018-10-31 07:20:45
depth1
children4
last_payout2018-11-07 07:20:45
cashout_time1969-12-31 23:59:59
total_payout_value7.232 HBD
curator_payout_value2.311 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,437
author_reputation448,535,049,068,622
root_title"Pywit Version 1.1.1 & Utopian-io Submission"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id74,391,086
net_rshares8,372,954,789,628
author_curate_reward""
vote details (11)
@petertag ·
Great, thanks for the errors you pointed out! I saw your comment on bobinson's post about pipfiles, I was wondering the reason you're not a big fan, since I don't have an opinion one way or the other yet. I had setup.py because it was easy to setup and figure out, basically for a quickstart, wasn't sure what the differences were when I was choosing one to use.
properties (22)
authorpetertag
permlinkre-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t200811101z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-10-31 20:07:42
last_update2018-10-31 20:07:42
depth2
children0
last_payout2018-11-07 20:07:42
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length362
author_reputation17,170,168,350,944
root_title"Pywit Version 1.1.1 & Utopian-io Submission"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id74,430,681
net_rshares0
@petertag ·
Hey again, do you have any docs on the witness_set_properties using the witness's public signing key?  So far I don't think beempy supports it, but I could look into setting up a workaround in pywit. Or is it just with the private signing key that you mean?
properties (22)
authorpetertag
permlinkre-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t205624956z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2018-10-31 20:55:57
last_update2018-10-31 20:55:57
depth2
children1
last_payout2018-11-07 20:55:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length257
author_reputation17,170,168,350,944
root_title"Pywit Version 1.1.1 & Utopian-io Submission"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id74,433,309
net_rshares0
@emrebeyler ·
You can sign with the private signing key. (witness key)

Check [here](https://github.com/emre/transmitter/blob/master/transmitter/main.py#L134) for an example for  witness_set_properties.
properties (22)
authoremrebeyler
permlinkre-petertag-re-emrebeyler-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181101t083703497z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://github.com/emre/transmitter/blob/master/transmitter/main.py#L134"],"app":"steemit/0.1"}
created2018-11-01 08:37:03
last_update2018-11-01 08:37:03
depth3
children0
last_payout2018-11-08 08:37:03
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length188
author_reputation448,535,049,068,622
root_title"Pywit Version 1.1.1 & Utopian-io Submission"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id74,462,365
net_rshares0
@utopian-io ·
Thank you for your review, @emrebeyler! Keep up the good work!
properties (22)
authorutopian-io
permlinkre-re-petertag-pywit-version-1-1-1-and-utopian-io-submission-20181031t072044678z-20181103t010922z
categoryutopian-io
json_metadata"{"app": "beem/0.20.9"}"
created2018-11-03 01:09:24
last_update2018-11-03 01:09:24
depth2
children0
last_payout2018-11-10 01:09:24
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length62
author_reputation152,955,367,999,756
root_title"Pywit Version 1.1.1 & Utopian-io Submission"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id74,574,130
net_rshares0