create account

RE: [HapRamp Web App] Adding User Search Feature by gregory.latinier

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @singhpratyush/hapramp-web-app-adding-user-search-feature

· @gregory.latinier · (edited)
$3.29
Hi! I remember your project from when you added SteemConnect. It's great to review your work again.

Let's go for the review:

- For React component you declare your propTypes and defaultProps outside the component like for stateless function. Any reason for this choice?

- Why the search is outside the folder structure? In the root directory I really wonder what's its purpose it first.

- `alpha-web/src/search/SearchBar/SearchBar.component.js` => This displacement of folder leads to weird naming. Why a component is outside the components folder?

- [Here](https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0) is an article by Dan Abramov that explains the difference between components and containers 

- Except for the weird folder choice, you're doing a good use of redux :)

- `alpha-web/src/components/` => Why do you have cases difference in the same folder ? 

- Nice to see the service worker for the PWA stuffs.

- like most people you got a few `console.log` that are only here for debug purpose.

- For clarity I would have 1 property per line but that's my preference.
![](https://cdn.steemitimages.com/DQmZBMDBHY2rUbtXMQBSQFv7bxjVdVkf8vija99zbPwZz9t/image.png)

- You should improve your readme.md with install stuff, roadmap, etc.

I'll stop here :) You added one new feature but it doesn't follow your folder structure that's a litlle sad. Any reason why it was coded like that?

So now what's coming next??? Good luck and keep up the work ;)


Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2332213).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)
👍  , , , ,
properties (23)
authorgregory.latinier
permlinkre-singhpratyush-hapramp-web-app-adding-user-search-feature-20180715t224103331z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"image":["https://cdn.steemitimages.com/DQmZBMDBHY2rUbtXMQBSQFv7bxjVdVkf8vija99zbPwZz9t/image.png"],"links":["https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2332213","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2018-07-15 22:41:03
last_update2018-07-15 22:43:45
depth1
children2
last_payout2018-07-22 22:41:03
cashout_time1969-12-31 23:59:59
total_payout_value2.471 HBD
curator_payout_value0.816 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,974
author_reputation34,278,323,818,021
root_title"[HapRamp Web App] Adding User Search Feature"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id64,803,639
net_rshares1,537,643,402,027
author_curate_reward""
vote details (5)
@singhpratyush ·
Hey @gregory.latinier

Thanks for reviewing the submission :)

The different folder structure is because I will be moving on from the flat directory structure. So once I am done with the refactoring, everything should be consistent.

We are planning to release the Android app on Google Play in August. We are also planning a small local meetup this weekend. Hoping to get a good response for the same.

Cheers!
properties (22)
authorsinghpratyush
permlinkre-gregorylatinier-re-singhpratyush-hapramp-web-app-adding-user-search-feature-20180717t070803879z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.2","format":"markdown","tags":["utopian-io"],"users":["gregory.latinier"],"links":["/@gregory.latinier"],"image":[]}
created2018-07-17 07:08:03
last_update2018-07-17 07:08:03
depth2
children0
last_payout2018-07-24 07:08:03
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length411
author_reputation7,035,648,262,478
root_title"[HapRamp Web App] Adding User Search Feature"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id64,958,528
net_rshares0
@utopian-io ·
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

**Contributing on Utopian**
Learn how to contribute on <a href="https://join.utopian.io">our website</a>.

**Want to chat? Join us on Discord https://discord.gg/h52nFrV.**

<a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for Utopian Witness!</a>
👍  
properties (23)
authorutopian-io
permlink20180716t100512523z
categoryutopian-io
json_metadata{"tags":["utopian.tip"],"app":"utopian-io"}
created2018-07-16 10:05:12
last_update2018-07-16 10:05:12
depth2
children0
last_payout2018-07-23 10:05:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length416
author_reputation152,955,367,999,756
root_title"[HapRamp Web App] Adding User Search Feature"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id64,851,298
net_rshares5,254,553,552
author_curate_reward""
vote details (1)