create account

RE: Open sourcing HapRamp Alpha web app and adding Travis CI by gregory.latinier

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @singhpratyush/open-sourcing-hapramp-alpha-web-app-and-adding-travis-ci

· @gregory.latinier ·
$7.08
So another project displaying the blockchain content. My big question here is what do offer that is different from Steemit or Busy ? How do you enhance the Steem user experience ?

Some features are missing and will certainly prevent users from using your app like server side rendering. When people share steemit or busy posts, the first image and a text extract are displayed. You don't support multilanguage.

Here are some advice for your development.

I see that you've organized your app with a flat structure. An actions, a reducers and a components folder. This is not really a good idea as your application will grow you will have a lot of files in this folders and it will be more and more difficult to develop. You should consider separating your app by components.

You should better organize your package.json. For instance `webpack` packages belong to the `devDependencies`.

And now some things that I really don't like I raise a big flag !!! Do not use this application while this is not changed.

https://github.com/hapramp/alpha-web/blob/b3edaa6773e8df033e44a8dbf26ad347dd30e366/src/reducers/loginReducer.js#L23 => your are STORING THE POSTING KEY ON LOCALSTORAGE !!! This is really really really problematic. What happens if a user browse your website on a public computer ? His posting key could be stolen !!! This is why SteemConnect have been created,  to ensure that some bad things like that aren't happening.

https://github.com/hapramp/alpha-web/blob/master/src/actions/loginActions.js#L43-L53 => What the hell are you doing ??? Why are you posting a comment using the user's account and then delete it afterwards ? You are doing an action without the users knowledge.

So there is some work and I think it deserve an utopian vote. But given the quality of the login I advise Steem users to stay away from this app. Wait for some changes.

Good luck for your future developments

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2312224).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , ,
properties (23)
authorgregory.latinier
permlinkre-singhpratyush-open-sourcing-hapramp-alpha-web-app-and-adding-travis-ci-20180605t074524854z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://github.com/hapramp/alpha-web/blob/b3edaa6773e8df033e44a8dbf26ad347dd30e366/src/reducers/loginReducer.js#L23","https://github.com/hapramp/alpha-web/blob/master/src/actions/loginActions.js#L43-L53","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2312224","https://support.utopian.io/","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2018-06-05 07:45:24
last_update2018-06-05 07:45:24
depth1
children2
last_payout2018-06-12 07:45:24
cashout_time1969-12-31 23:59:59
total_payout_value6.447 HBD
curator_payout_value0.629 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length2,395
author_reputation34,278,323,818,021
root_title"Open sourcing HapRamp Alpha web app and adding Travis CI"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id59,334,128
net_rshares2,148,945,171,061
author_curate_reward""
vote details (7)
@singhpratyush ·
Hi @gregory.latinier, thanks a lot for the time you spent on this deep analysis of the app.

We are still developing the application and improving it day by day. We are well aware of the problems that you mentioned and that's why we haven't released it for public use yet.

---
> I see that you've organized your app with a flat structure.

Yes, the structure at the moment is flat and we need to change it. When I started working on the project, I wasn't good at React and I'm still learning it. We hope that making the project open source helps us increase the quality of code in the project.

> You should consider separating your app by components.

This is certainly true and is being acted upon by us.

---

The login flow (the one with an automatic user comment) that we used and `localstorage` are certainly not good. We were just experimenting things a long time ago (sometime in Feb 2018). But we have lined up SteemConnect integration in our development timeline and will start working on it soon.

---

I request you to go through [this](https://busy.org/@hapramp/introducing-hapramp-project-a-steem-based-social-network-from-india-for-creative-communities) blog post and let us know what you think. I hope this would resolve some of the queries that you pointed out in the beginning.

--- 

Based on your comment, I have created a [few issues](https://github.com/hapramp/alpha-web/issues) on Github. We request you to report more issues as it would help us explore more priority action points.

---

Finally, I would like to thank you a lot on behalf of the whole team for this feedback. The Utopian community is really great and we are overwhelmed with such support and response from it.  We are working hard to make more contributions to the open source community and Steem ecosystem.

--
Pratyush
properties (22)
authorsinghpratyush
permlinkre-gregorylatinier-re-singhpratyush-open-sourcing-hapramp-alpha-web-app-and-adding-travis-ci-20180605t093627249z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"community":"busy","app":"busy/2.4.0"}
created2018-06-05 09:36:30
last_update2018-06-05 09:36:30
depth2
children0
last_payout2018-06-12 09:36:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,812
author_reputation7,035,648,262,478
root_title"Open sourcing HapRamp Alpha web app and adding Travis CI"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id59,345,871
net_rshares0
@utopian-io ·
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

**Contributing on Utopian**
Learn how to contribute on <a href="https://join.utopian.io">our website</a>.

**Want to chat? Join us on Discord https://discord.gg/h52nFrV.**

<a href="https://v2.steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1">Vote for Utopian Witness!</a>
properties (22)
authorutopian-io
permlink20180605t075112645z
categoryutopian-io
json_metadata{"tags":["utopian.tip"],"app":"utopian-io"}
created2018-06-05 07:51:12
last_update2018-06-05 07:51:12
depth2
children0
last_payout2018-06-12 07:51:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length416
author_reputation152,955,367,999,756
root_title"Open sourcing HapRamp Alpha web app and adding Travis CI"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id59,334,734
net_rshares0