create account

RE: Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation by justyy

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @creatrixity/adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation

· @justyy ·
$10.21
Thank you for your contribution.

You probably can use a single variable `mode` (which can be enum) to determine if it is API or REST, which will make the logics a lot simpler.

The [copyAppStarterFiles](https://github.com/creatrixity/adonis-auth-scaffold/blob/1c098fba002f3354842fb2067412b98a4fc0b8b1/commands/MakeAuth.js#L311) appears to me requiring a parameter client, but on the code, it passes nothing, do this code work?

For the line append/prepend, have you considered the line endings on Linux, Windows or MAC? `\n`, `\n\r` or `\r`?

You may want to check if a file has been prepended using a better approach rather than `if (fileContents[lineNumber] === lineContent) return;` . 

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-1-2-2-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , , , , , , ,
properties (23)
authorjustyy
permlinkre-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190314t212110987z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://github.com/creatrixity/adonis-auth-scaffold/blob/1c098fba002f3354842fb2067412b98a4fc0b8b1/commands/MakeAuth.js#L311","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-3-2-1-2-2-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2019-03-14 21:21:15
last_update2019-03-14 21:21:15
depth1
children2
last_payout2019-03-21 21:21:15
cashout_time1969-12-31 23:59:59
total_payout_value7.758 HBD
curator_payout_value2.450 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,139
author_reputation280,616,224,641,976
root_title"Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,320,349
net_rshares14,996,329,284,408
author_curate_reward""
vote details (23)
@creatrixity ·
Great insight. The v1.1.1 fix will address these issues.
properties (22)
authorcreatrixity
permlinkre-justyy-re-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190315t061618935z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit/0.1"}
created2019-03-15 06:20:15
last_update2019-03-15 06:20:15
depth2
children0
last_payout2019-03-22 06:20:15
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length56
author_reputation16,463,772,859,893
root_title"Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,341,617
net_rshares0
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
authorutopian-io
permlinkre-re-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190314t212110987z-20190317t040239z
categoryutopian-io
json_metadata"{"app": "beem/0.20.17"}"
created2019-03-17 04:02:39
last_update2019-03-17 04:02:39
depth2
children0
last_payout2019-03-24 04:02:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length58
author_reputation152,955,367,999,756
root_title"Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id81,442,817
net_rshares0