Viewing a response to: @creatrixity/adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation
Thank you for your contribution. You probably can use a single variable `mode` (which can be enum) to determine if it is API or REST, which will make the logics a lot simpler. The [copyAppStarterFiles](https://github.com/creatrixity/adonis-auth-scaffold/blob/1c098fba002f3354842fb2067412b98a4fc0b8b1/commands/MakeAuth.js#L311) appears to me requiring a parameter client, but on the code, it passes nothing, do this code work? For the line append/prepend, have you considered the line endings on Linux, Windows or MAC? `\n`, `\n\r` or `\r`? You may want to check if a file has been prepended using a better approach rather than `if (fileContents[lineNumber] === lineContent) return;` . Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-1-2-2-1-). ---- Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
author | justyy |
---|---|
permlink | re-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190314t212110987z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https://github.com/creatrixity/adonis-auth-scaffold/blob/1c098fba002f3354842fb2067412b98a4fc0b8b1/commands/MakeAuth.js#L311","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-3-2-1-2-2-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"} |
created | 2019-03-14 21:21:15 |
last_update | 2019-03-14 21:21:15 |
depth | 1 |
children | 2 |
last_payout | 2019-03-21 21:21:15 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 7.758 HBD |
curator_payout_value | 2.450 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 1,139 |
author_reputation | 280,616,224,641,976 |
root_title | "Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 81,320,349 |
net_rshares | 14,996,329,284,408 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
happyukgo | 0 | 514,753,905 | 25% | ||
lordneroo | 0 | 45,832,122,738 | 50% | ||
codingdefined | 0 | 26,595,320,613 | 20% | ||
superbing | 0 | 2,554,719,475 | 25% | ||
dailyfortune | 0 | 36,914,896 | 25% | ||
espoem | 0 | 29,059,358,649 | 15% | ||
dailystats | 0 | 7,473,472,303 | 25% | ||
utopian-io | 0 | 14,708,934,875,679 | 10.49% | ||
jaff8 | 0 | 42,870,051,936 | 17.78% | ||
cheneats | 0 | 493,182,959 | 12.5% | ||
amosbastian | 0 | 61,324,136,297 | 17.78% | ||
dailychina | 0 | 7,069,849,557 | 25% | ||
reazuliqbal | 0 | 17,961,087,780 | 10% | ||
amico | 0 | 1,786,368,009 | 0.6% | ||
turtlegraphics | 0 | 2,446,292,645 | 25% | ||
ulockblock | 0 | 10,594,697,276 | 3.52% | ||
witnesstools | 0 | 2,358,335,754 | 25% | ||
ilovecoding | 0 | 2,342,768,128 | 25% | ||
curbot | 0 | 2,379,669,477 | 100% | ||
steemfuckeos | 0 | 1,527,471,106 | 25% | ||
ascorphat | 0 | 2,373,765,068 | 2.5% | ||
yff | 0 | 19,472,594,387 | 100% | ||
curatortrail | 0 | 327,475,771 | 95% |
Great insight. The v1.1.1 fix will address these issues.
author | creatrixity |
---|---|
permlink | re-justyy-re-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190315t061618935z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"app":"steemit/0.1"} |
created | 2019-03-15 06:20:15 |
last_update | 2019-03-15 06:20:15 |
depth | 2 |
children | 0 |
last_payout | 2019-03-22 06:20:15 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 56 |
author_reputation | 16,463,772,859,893 |
root_title | "Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 81,341,617 |
net_rshares | 0 |
Thank you for your review, @justyy! Keep up the good work!
author | utopian-io |
---|---|
permlink | re-re-creatrixity-adonis-auth-scaffold-development-update-api-http-client-authentication-code-generation-20190314t212110987z-20190317t040239z |
category | utopian-io |
json_metadata | "{"app": "beem/0.20.17"}" |
created | 2019-03-17 04:02:39 |
last_update | 2019-03-17 04:02:39 |
depth | 2 |
children | 0 |
last_payout | 2019-03-24 04:02:39 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 HBD |
curator_payout_value | 0.000 HBD |
pending_payout_value | 0.000 HBD |
promoted | 0.000 HBD |
body_length | 58 |
author_reputation | 152,955,367,999,756 |
root_title | "Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 HBD |
percent_hbd | 10,000 |
post_id | 81,442,817 |
net_rshares | 0 |