Viewing a response to: @dehenne/tasks-api-implementation-into-the-php-client-for-makerlog
hiveblocksThank you for your contribution.
1. The build is failing on the github page.
2. It would be nice to have some unit tests to cover the new classes you added.
3. The `refresh()` is actually clearing the caching (doesn't do what exactly it says), it would be better to move (or re-organise) the correct logics e.g the code in `getTaskdata` into this function.
4. Often, the chainning such as `$this->Makerlog->getRequest()->get('/tasks/sync/');` is a code smell, because something may be null in the middle, try to have `if null` check, then throw exception accordingly.
Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-2-1-).
----
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).
[[utopian-moderator]](https://join.utopian.io/)| author | justyy |
|---|---|
| permlink | re-dehenne-tasks-api-implementation-into-the-php-client-for-makerlog-20190309t210027955z |
| category | utopian-io |
| json_metadata | {"tags":["utopian-io"],"links":["https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-2-2-2-2-2-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"} |
| created | 2019-03-09 21:00:30 |
| last_update | 2019-03-09 21:00:30 |
| depth | 1 |
| children | 2 |
| last_payout | 2019-03-16 21:00:30 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 9.620 HBD |
| curator_payout_value | 3.043 HBD |
| pending_payout_value | 0.000 HBD |
| promoted | 0.000 HBD |
| body_length | 1,018 |
| author_reputation | 280,616,224,641,976 |
| root_title | "Tasks API implementation into the PHP Client for Makerlog" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 HBD |
| percent_hbd | 10,000 |
| post_id | 80,981,223 |
| net_rshares | 17,927,792,910,688 |
| author_curate_reward | "" |
| voter | weight | wgt% | rshares | pct | time |
|---|---|---|---|---|---|
| happyukgo | 0 | 514,753,905 | 25% | ||
| codingdefined | 0 | 28,467,999,211 | 20% | ||
| superbing | 0 | 2,504,625,987 | 25% | ||
| dailyfortune | 0 | 36,914,896 | 25% | ||
| espoem | 0 | 26,673,450,966 | 15% | ||
| dailystats | 0 | 7,401,511,209 | 25% | ||
| utopian-io | 0 | 17,684,268,759,249 | 12.55% | ||
| jaff8 | 0 | 42,107,042,879 | 19.27% | ||
| amosbastian | 0 | 59,248,451,486 | 19.27% | ||
| dailychina | 0 | 6,917,958,480 | 25% | ||
| reazuliqbal | 0 | 17,834,030,376 | 10% | ||
| amico | 0 | 1,802,024,123 | 0.6% | ||
| pcsg-dev | 0 | 2,066,807,263 | 100% | ||
| turtlegraphics | 0 | 2,423,856,999 | 25% | ||
| ulockblock | 0 | 15,865,418,467 | 4.91% | ||
| witnesstools | 0 | 2,336,932,442 | 25% | ||
| ilovecoding | 0 | 2,320,252,099 | 25% | ||
| curbot | 0 | 2,554,941,153 | 100% | ||
| steemfuckeos | 0 | 1,513,161,110 | 25% | ||
| ascorphat | 0 | 1,970,209,895 | 2.5% | ||
| yff | 0 | 18,638,648,469 | 100% | ||
| curatortrail | 0 | 325,160,024 | 95% |
> The build is failing on the github page. yes, there is an issue for that. it's an issue with travis-ci and i have no solution at the moment :( > The refresh() is actually clearing the caching (doesn't do what exactly it says), it would be better to move (or re-organise) the correct logics e.g the code in getTaskdata into this function. good argument. I will take to heart oh, and thanks for the improvement suggestions
| author | dehenne |
|---|---|
| permlink | re-justyy-re-dehenne-tasks-api-implementation-into-the-php-client-for-makerlog-20190310t160303178z |
| category | utopian-io |
| json_metadata | {"tags":["utopian-io"],"app":"steemit/0.1"} |
| created | 2019-03-10 16:03:03 |
| last_update | 2019-03-10 16:03:42 |
| depth | 2 |
| children | 0 |
| last_payout | 2019-03-17 16:03:03 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 0.000 HBD |
| curator_payout_value | 0.000 HBD |
| pending_payout_value | 0.000 HBD |
| promoted | 0.000 HBD |
| body_length | 425 |
| author_reputation | 8,032,043,781,732 |
| root_title | "Tasks API implementation into the PHP Client for Makerlog" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 HBD |
| percent_hbd | 10,000 |
| post_id | 81,021,031 |
| net_rshares | 0 |
Thank you for your review, @justyy! Keep up the good work!
| author | utopian-io |
|---|---|
| permlink | re-re-dehenne-tasks-api-implementation-into-the-php-client-for-makerlog-20190309t210027955z-20190312t035706z |
| category | utopian-io |
| json_metadata | "{"app": "beem/0.20.17"}" |
| created | 2019-03-12 03:57:09 |
| last_update | 2019-03-12 03:57:09 |
| depth | 2 |
| children | 0 |
| last_payout | 2019-03-19 03:57:09 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 0.000 HBD |
| curator_payout_value | 0.000 HBD |
| pending_payout_value | 0.000 HBD |
| promoted | 0.000 HBD |
| body_length | 58 |
| author_reputation | 152,955,367,999,756 |
| root_title | "Tasks API implementation into the PHP Client for Makerlog" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 HBD |
| percent_hbd | 10,000 |
| post_id | 81,111,569 |
| net_rshares | 0 |