RE: [KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution) by justyy

View this thread on: hive.blog | peakd.com | ecency.com

Viewing a response to: @jaysermendez/knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution

utopian-io · @justyy · Jan 28 '19

$10.30

Thank you very much for your contribution @jaysermendez ! 

1. it might be better to have delegations data obtained from blockchain instead of being hard-coded in `delegations.json`. This does not need to be at real time - I think you can do this in a separate process running at background periodically. Or, you can use @steemsql
2. IMHO, i am not a big fan of posting templated comments on blockchain. It is kinda of spam - and it costs RC. You might want to introduce mechanisim to control the frequency of posting.
3. Do you really want to check-in the `yarn.lock` according to [this](https://github.com/yarnpkg/yarn/issues/838)?



Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-1-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, jaff8, amosbastian, espoem, codingdefined, reazuliqbal, ulockblock, dailystats, dailychina, jaysermendez, curbot, turtlegraphics, witnesstools, ilovecoding, ascorphat, superbing, steemfuckeos, happyukgo, dailyfortune

`author`	justyy
`permlink`	re-jaysermendez-knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution-20190128t080401723z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"users":["jaysermendez","steemsql"],"links":["https://github.com/yarnpkg/yarn/issues/838","https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-2-2-2-2-1-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
`created`	2019-01-28 08:04:03
`last_update`	2019-01-28 08:04:03
`depth`	1
`children`	5
`last_payout`	2019-02-04 08:04:03
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	7.796 HBD
`curator_payout_value`	2.500 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	1,085
`author_reputation`	280,616,224,641,976
`root_title`	"[KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	79,048,807
`net_rshares`	20,679,868,337,254
`author_curate_reward`	""

properties (23)vote details (19)

voter	rshares	pct
happyukgo	463,729,450	25%
codingdefined	23,559,099,110	20%
superbing	2,142,828,892	25%
dailyfortune	29,074,426	25%
espoem	28,325,386,252	15%
dailystats	6,141,889,885	25%
utopian-io	20,385,972,529,150	14.79%
jaff8	124,992,501,633	75%
amosbastian	59,275,834,896	23.49%
dailychina	5,913,746,429	25%
jaysermendez	3,963,934,685	100%
reazuliqbal	13,783,662,955	10%
turtlegraphics	2,258,855,452	25%
ulockblock	12,843,594,211	4.62%
witnesstools	2,177,537,911	25%
ilovecoding	2,152,565,178	25%
curbot	2,324,111,708	100%
steemfuckeos	1,402,530,288	25%
ascorphat	2,144,924,743	2.5%

@jaysermendez · Jan 28 '19

Hello @justyy,

Thanks for the suggestions. I didn't realize about the yarn.lock being committed. Will surely remove it.

Regarding delegations.json, this is not hardcoded. It is served as a baseline for seeding purposes and it is patched with deltas thereafter. Before each distribution, it is patched with the latest data.

Regarding the comment template, @knowledges what do you think?

properties (22)

`author`	jaysermendez
`permlink`	re-justyy-re-jaysermendez-knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution-20190128t080803778z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"users":["justyy","knowledges"],"app":"steemit/0.1"}
`created`	2019-01-28 08:08:03
`last_update`	2019-01-28 08:08:03
`depth`	2
`children`	0
`last_payout`	2019-02-04 08:08:03
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	388
`author_reputation`	20,790,862,502,465
`root_title`	"[KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	79,048,917
`net_rshares`	0

@jaysermendez · Jan 28 '19

Here is the sync script :) https://github.com/knacksteem/knacksteem-api/blob/master/src/api/pollers/delegators.poller.js

properties (22)

`author`	jaysermendez
`permlink`	re-justyy-re-jaysermendez-knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution-20190128t081749971z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"links":["https://github.com/knacksteem/knacksteem-api/blob/master/src/api/pollers/delegators.poller.js"],"app":"steemit/0.1"}
`created`	2019-01-28 08:17:51
`last_update`	2019-01-28 08:17:51
`depth`	2
`children`	1
`last_payout`	2019-02-04 08:17:51
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	120
`author_reputation`	20,790,862,502,465
`root_title`	"[KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	79,049,202
`net_rshares`	0

@justyy · Jan 28 '19 (edited)

Thanks. In this case you might not want to check in this file ‘delegation.json’ as well. ;)

Posted using [Partiko iOS](https://steemit.com/@partiko-ios)

👍 dailystats, dailychina, curbot, turtlegraphics, witnesstools, ilovecoding, superbing, steemfuckeos, happyukgo, dailyfortune

`author`	justyy
`permlink`	justyy-re-jaysermendez-re-justyy-re-jaysermendez-knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution-20190128t095024575z
`category`	utopian-io
`json_metadata`	{"app":"partiko","client":"ios"}
`created`	2019-01-28 09:50:24
`last_update`	2019-01-28 09:50:48
`depth`	3
`children`	0
`last_payout`	2019-02-04 09:50:24
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	153
`author_reputation`	280,616,224,641,976
`root_title`	"[KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	79,051,772
`net_rshares`	25,013,179,806
`author_curate_reward`	""

properties (23)vote details (10)

voter	rshares	pct
happyukgo	465,314,170	25%
superbing	2,149,401,482	25%
dailyfortune	29,318,964	25%
dailystats	6,161,020,264	25%
dailychina	5,908,595,106	25%
turtlegraphics	2,266,108,316	25%
witnesstools	2,184,544,152	25%
ilovecoding	2,168,355,150	25%
curbot	2,267,555,735	100%
steemfuckeos	1,412,966,467	25%

@knowledges · Jan 28 '19

> I am not a big fan of posting templated comments on blockchain.

The comment is made under each approved and scored knacksteem post. Very similar to what Utopian and other similar projects on the blockchain does. I don't consider this as spamming.

As for the delegation.json, it may look hard-coded but its not. It serves only as a baseline for seeding as explained by @jaysermendez

properties (22)

`author`	knowledges
`permlink`	re-justyy-re-jaysermendez-knacksteem-api-delegators-tokens-distribution-bot-curation-bot-voting-commenting-knt-distribution-20190128t081715277z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"users":["jaysermendez"],"app":"steemit/0.1"}
`created`	2019-01-28 08:17:18
`last_update`	2019-01-28 08:17:18
`depth`	2
`children`	0
`last_payout`	2019-02-04 08:17:18
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 HBD
`curator_payout_value`	0.000 HBD
`pending_payout_value`	0.000 HBD
`promoted`	0.000 HBD
`body_length`	385
`author_reputation`	98,021,227,622,369
`root_title`	"[KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 HBD
`percent_hbd`	10,000
`post_id`	79,049,187
`net_rshares`	0

@utopian-io · Jan 30 '19

Thank you for your review, @justyy! Keep up the good work!

properties (22)