create account

RE: QUIQQER Order Module - Multi Currency Feature by justyy

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @pcsg-dev/quiqqer-order-module-multi-currency-feature

· @justyy ·
$16.24
Thank you for your contribution.

1. You probably can chain your calls such as `$TemporaryInvoice->getArticles()->setUser($this->getCustomer())->setCurrency($this->getCurrency()` as currently the `getArticles()` has been invoked twice.
2. Two places of comment-out code - better to remove them to keep your codebase clean.
3. When users switch from one currency to another, it's better to conert the value automatically using third party currency converter API.
4. No unit tests found to cover the functionalities.


Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-2-2-2-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , , , , , ,
properties (23)
authorjustyy
permlinkre-pcsg-dev-quiqqer-order-module-multi-currency-feature-20190331t205633473z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-3-2-2-2-2-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2019-03-31 20:56:36
last_update2019-03-31 20:56:36
depth1
children1
last_payout2019-04-07 20:56:36
cashout_time1969-12-31 23:59:59
total_payout_value12.305 HBD
curator_payout_value3.934 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length965
author_reputation280,616,224,641,976
root_title"QUIQQER Order Module - Multi Currency Feature"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id82,271,765
net_rshares22,057,825,103,692
author_curate_reward""
vote details (22)
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
authorutopian-io
permlinkre-re-pcsg-dev-quiqqer-order-module-multi-currency-feature-20190331t205633473z-20190403t000737z
categoryutopian-io
json_metadata"{"app": "beem/0.20.17"}"
created2019-04-03 00:07:39
last_update2019-04-03 00:07:39
depth2
children0
last_payout2019-04-10 00:07:39
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length58
author_reputation152,955,367,999,756
root_title"QUIQQER Order Module - Multi Currency Feature"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id82,394,118
net_rshares0