create account

RE: Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc by blockchainstudio

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @justyy/re-blockchainstudio-busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc-20190201t155404703z

· @blockchainstudio · (edited)
Hi @justyy, thanks a lot for your review and very detailed suggestions.
Re 1: Of course, I actually thought about this (especially for hacking prevention, but it isn't that simple. I mean without changing the original code too much. Since I'm an external contributor, so I've decided not to change too much the code. But I guess now I got some trust from Busy team :) so maybe more substantial change will come :)
Re 2: You're right, at that time, I forgot to add the test code.
Re 3: Again you're right. The reason why I just hardcoded it was the original code was with such magic numbers in some cases (of course when it's very simple and only used there once like in this case), so I followed their practice. As you can see, the entire class and file is quite short. But in general I totally agree with you. This is actually the difficulty of contributing to the already established open-source project as external contributor :) sometimes I don't agree with the style, but I think I should follow their style unless the change is absolutely needed.

Many thanks again!
properties (22)
authorblockchainstudio
permlinkre-justyy-re-blockchainstudio-busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc-20190201t161128239z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["justyy"],"links":["/@justyy"],"image":[]}
created2019-02-01 16:09:00
last_update2019-02-01 16:11:09
depth2
children0
last_payout2019-02-08 16:09:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,072
author_reputation178,988,499,015,921
root_title"Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,262,331
net_rshares0