create account

RE: Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc by justyy

View this thread on: hive.blogpeakd.comecency.com

Viewing a response to: @blockchainstudio/busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc

· @justyy ·
$11.57
Thank you for your contribution!

1. Maybe you can also show power down route (if applicable) - and enable a cancel power down option?
2. Tests would be nice to cover the functions e.g. `calculatePendingWithdrawalSP`
3. Thanks for sharing that $0.02 payout information - which you might replace the 0.02 with `STEEM_MIN_PAYOUT_SBD` as you mentioned in the comment.

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-2-2-1-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , , , , , , ,
properties (23)
authorjustyy
permlinkre-blockchainstudio-busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc-20190201t155404703z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https://join.utopian.io/guidelines","https://review.utopian.io/result/3/2-3-2-2-2-1-1-","https://discord.gg/uTyJkNm","https://join.utopian.io/"],"app":"steemit/0.1"}
created2019-02-01 15:54:06
last_update2019-02-01 15:54:06
depth1
children2
last_payout2019-02-08 15:54:06
cashout_time1969-12-31 23:59:59
total_payout_value8.751 HBD
curator_payout_value2.818 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length814
author_reputation280,616,224,641,976
root_title"Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,261,730
net_rshares23,884,970,461,008
author_curate_reward""
vote details (23)
@blockchainstudio · (edited)
Hi @justyy, thanks a lot for your review and very detailed suggestions.
Re 1: Of course, I actually thought about this (especially for hacking prevention, but it isn't that simple. I mean without changing the original code too much. Since I'm an external contributor, so I've decided not to change too much the code. But I guess now I got some trust from Busy team :) so maybe more substantial change will come :)
Re 2: You're right, at that time, I forgot to add the test code.
Re 3: Again you're right. The reason why I just hardcoded it was the original code was with such magic numbers in some cases (of course when it's very simple and only used there once like in this case), so I followed their practice. As you can see, the entire class and file is quite short. But in general I totally agree with you. This is actually the difficulty of contributing to the already established open-source project as external contributor :) sometimes I don't agree with the style, but I think I should follow their style unless the change is absolutely needed.

Many thanks again!
properties (22)
authorblockchainstudio
permlinkre-justyy-re-blockchainstudio-busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc-20190201t161128239z
categoryutopian-io
json_metadata{"community":"busy","app":"busy/2.5.6","format":"markdown","tags":["utopian-io"],"users":["justyy"],"links":["/@justyy"],"image":[]}
created2019-02-01 16:09:00
last_update2019-02-01 16:11:09
depth2
children0
last_payout2019-02-08 16:09:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length1,072
author_reputation178,988,499,015,921
root_title"Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,262,331
net_rshares0
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
authorutopian-io
permlinkre-re-blockchainstudio-busy-3-new-features-and-2-bug-fixes-powerdown-information-zero-payout-3-digit-precision-etc-20190201t155404703z-20190203t200241z
categoryutopian-io
json_metadata"{"app": "beem/0.20.17"}"
created2019-02-03 20:02:42
last_update2019-02-03 20:02:42
depth2
children0
last_payout2019-02-10 20:02:42
cashout_time1969-12-31 23:59:59
total_payout_value0.000 HBD
curator_payout_value0.000 HBD
pending_payout_value0.000 HBD
promoted0.000 HBD
body_length58
author_reputation152,955,367,999,756
root_title"Busy - 3 new features and 2 bug fixes - powerdown information, zero payout, 3-digit precision, etc"
beneficiaries[]
max_accepted_payout1,000,000.000 HBD
percent_hbd10,000
post_id79,354,384
net_rshares0